-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix path warning on windows #629
Conversation
Previously this was rendering as %!U(MISSING)SERPROFILE%!\(MISSING).krew\bin while installing on windows. Using %% solves that. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
I also had to update the tests because the function actually has to return The /assign @corneliusweig |
os.Setenv("KREW_OS", "windows") | ||
defer func() { os.Unsetenv("KREW_OS") }() | ||
instructions := SetupInstructions() | ||
t.Log(instructions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: intentional?
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously this was rendering as
while installing on windows. Using %% solves that.