Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation instructions #635

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Update installation instructions #635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
088c4b7
Update installation instructions
chriskim06 Aug 19, 2020
30a1a49
Remove extra line
chriskim06 Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions site/content/docs/user-guide/setup/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,10 @@ Krew self-hosts).
```sh
(
set -x; cd "$(mktemp -d)" &&
curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/latest/download/krew.{tar.gz,yaml}" &&
curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/latest/download/krew.tar.gz" &&
tar zxvf krew.tar.gz &&
KREW=./krew-"$(uname | tr '[:upper:]' '[:lower:]')_amd64" &&
"$KREW" install --manifest=krew.yaml --archive=krew.tar.gz &&
"$KREW" update
"$KREW" install krew
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you updated the wrong part?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops good catch, let me fix that

)
```

Expand All @@ -49,11 +48,10 @@ Krew self-hosts).
```fish
begin
set -x; set temp_dir (mktemp -d); cd "$temp_dir" &&
curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/latest/download/krew.{tar.gz,yaml}" &&
curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/latest/download/krew.tar.gz" &&
tar zxvf krew.tar.gz &&
set KREWNAME krew-(uname | tr '[:upper:]' '[:lower:]')_amd64 &&
./$KREWNAME install \
--manifest=krew.yaml --archive=krew.tar.gz &&
./$KREWNAME install krew &&
set -e KREWNAME; set -e temp_dir
end
```
Expand All @@ -72,14 +70,12 @@ Krew self-hosts).
## Windows {#windows}

1. Make sure `git` is installed on your system.
1. Download `krew.exe` and `krew.yaml` from the [Releases][releases] page to
a directory.
1. Download `krew.exe` from the [Releases][releases] page to a directory.
1. Launch a command-line window (`cmd.exe`) and navigate to that directory.
1. Run the following command to install krew (pass the correct
paths to `krew.yaml` and `krew.zip` below):
1. Run the following command to install krew:

```sh
krew install --manifest=krew.yaml
krew install krew
```

1. Add `%USERPROFILE%\.krew\bin` directory to your `PATH` environment variable
Expand Down