-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon #650
Add favicon #650
Conversation
site/layouts/partials/header.html
Outdated
@@ -14,6 +14,7 @@ | |||
</title> | |||
<link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" integrity="sha384-Vkoo8x4CGsO3+Hhxv8T/Q5PaXtkKtu6ug5TOeNV6gBiFeWPGFN9MuhOf23Q9Ifjh" crossorigin="anonymous"> | |||
<link rel="stylesheet" href="{{"/css/style.css" | relURL}}" /> | |||
<link rel="icon" href="{{"/img/favicon.svg"}}" type="image/svg" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you follow the | relURL
method as above. that basically ensures that if we someday host the site on /site, we can still have /site/img/favicon
Seems to be working on preview. 👍🏼 One nit. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, chriskim06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice, thanks! |
Noticed there wasn't a favicon in the docs. Not sure if this is wanted, if not feel free to close
/area docs
/cc @ahmetb
/cc @corneliusweig