-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic plugins list in the website #658
Merged
k8s-ci-robot
merged 9 commits into
kubernetes-sigs:master
from
ahmetb:netlify-dynamic-content
Oct 24, 2020
Merged
Dynamic plugins list in the website #658
k8s-ci-robot
merged 9 commits into
kubernetes-sigs:master
from
ahmetb:netlify-dynamic-content
Oct 24, 2020
Commits on Oct 9, 2020
-
Dynamic plugins list in the website
This relies on Netlify's serverless functions capability to render plugin count (in the homepage) and plugin list (/docs/plugins) in the website! The serverless function is called "api" and it's accessible on path /.netlify/functions/api/* and has two subpaths that return JSON responses: 1. */pluginCount 2. */plugins This serverless function is built by placing a binary in /site/functions named "api" and the build instruction is in 'netlify.toml' file. Since we get plugin list by calling GitHub API, by default we run without an authentication token. However after this is merged, I will go and add a permissionless $GITHUB_ACCESS_TOKEN that I have created from my account. Unauthenticated GitHub calls are limited to 60 per IP, but since I'll add a personal access token, that should not be an issue. When debugging locally, 60 is also fine. (deploy previews for PRs from non-maintainers will not have an access token available, so they will make unauthenticated calls to GH API.) The responses from the dynamic functions are actually cached in Netlify's CDN and that helps with the rate-limiting as well. I have currently set the CDN cache duration to 1 hour for each response. Please take a look at the previews and let me know if there is anything that doesn't look good. I might delete `generate-plugin-overview` tool and update the current plugins.md in a followup PR. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Configuration menu - View commit details
-
Copy full SHA for 66f683b - Browse repository at this point
Copy the full SHA 66f683bView commit details
Commits on Oct 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 59a65d9 - Browse repository at this point
Copy the full SHA 59a65d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf10f65 - Browse repository at this point
Copy the full SHA bf10f65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 871f617 - Browse repository at this point
Copy the full SHA 871f617View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6796c89 - Browse repository at this point
Copy the full SHA 6796c89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82c1f86 - Browse repository at this point
Copy the full SHA 82c1f86View commit details
Commits on Oct 19, 2020
-
add setup/debugging documentation
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Configuration menu - View commit details
-
Copy full SHA for 9100f2e - Browse repository at this point
Copy the full SHA 9100f2eView commit details
Commits on Oct 21, 2020
-
move from /docs/plugins to /plugins
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Configuration menu - View commit details
-
Copy full SHA for 543f132 - Browse repository at this point
Copy the full SHA 543f132View commit details -
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Configuration menu - View commit details
-
Copy full SHA for fb0b188 - Browse repository at this point
Copy the full SHA fb0b188View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.