Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic plugins list in the website #658

Merged
merged 9 commits into from
Oct 24, 2020

Commits on Oct 9, 2020

  1. Dynamic plugins list in the website

    This relies on Netlify's serverless functions capability to render
    plugin count (in the homepage) and plugin list (/docs/plugins) in
    the website!
    
    The serverless function is called "api" and it's accessible on path
    /.netlify/functions/api/* and has two subpaths that return JSON responses:
    
    1. */pluginCount
    2. */plugins
    
    This serverless function is built by placing a binary in /site/functions
    named "api" and the build instruction is in 'netlify.toml' file.
    
    Since we get plugin list by calling GitHub API, by default we run without
    an authentication token. However after this is merged, I will go and add a
    permissionless $GITHUB_ACCESS_TOKEN that I have created from my account.
    
    Unauthenticated GitHub calls are limited to 60 per IP, but since I'll add a
    personal access token, that should not be an issue. When debugging locally,
    60 is also fine. (deploy previews for PRs from non-maintainers will not have
    an access token available, so they will make unauthenticated calls to GH API.)
    
    The responses from the dynamic functions are actually cached in Netlify's
    CDN and that helps with the rate-limiting as well. I have currently set the
    CDN cache duration to 1 hour for each response.
    
    Please take a look at the previews and let me know if there is anything that
    doesn't look good.
    
    I might delete `generate-plugin-overview` tool and update the current
    plugins.md in a followup PR.
    
    Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
    ahmetb committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    66f683b View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2020

  1. Apply review comments

    corneliusweig authored and ahmetb committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    59a65d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf10f65 View commit details
    Browse the repository at this point in the history
  3. Simplify work sharing with errgroup

    corneliusweig authored and ahmetb committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    871f617 View commit details
    Browse the repository at this point in the history
  4. Satisfy impi constraints

    corneliusweig authored and ahmetb committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    6796c89 View commit details
    Browse the repository at this point in the history
  5. fix import

    Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
    ahmetb committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    82c1f86 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. add setup/debugging documentation

    Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
    ahmetb committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    9100f2e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. move from /docs/plugins to /plugins

    Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
    ahmetb committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    543f132 View commit details
    Browse the repository at this point in the history
  2. add /plugins to navbar

    Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
    ahmetb committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    fb0b188 View commit details
    Browse the repository at this point in the history