Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : sanitize PATH dir #665

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix : sanitize PATH dir #665

merged 1 commit into from
Nov 17, 2020

Conversation

RouxAntoine
Copy link
Contributor

Actually comparison between .krew/bin directory and path segment directory
is done with equal operator. This PR allow method filepath. Abs to be call during krew path creation
/internal/environment/environment.go#L43 and also in /cmd/krew/cmd/internal/setup_check.go#L62 path directory iteration

Fixes #664

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @RouxAntoine!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2020
corneliusweig
corneliusweig reviewed Nov 15, 2020
View reviewed changes
Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I left some nit comments, otherwise this looks good.

When you push your next revision, please @ me, then I'll take a look more quickly.

cmd/krew/cmd/internal/setup_check.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check.go Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
@RouxAntoine
Copy link
Contributor Author

@corneliusweig I fix your review, with just one reserve. Thanks for your review

corneliusweig
corneliusweig reviewed Nov 15, 2020
View reviewed changes
Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some last nits and then let's merge this!

cmd/krew/cmd/internal/setup_check.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
cmd/krew/cmd/internal/setup_check_test.go Outdated Show resolved Hide resolved
@RouxAntoine
Copy link
Contributor Author

RouxAntoine commented Nov 15, 2020 •
edited

Just some last nits and then let's merge this!

Second fix batch in commit e102013. Do you see my response here #665 (comment) ?

@corneliusweig

@corneliusweig
Copy link
Contributor

/approve
I'll wait for you if you want to change the shadowing glitch that I lured you into. Please @ me.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@RouxAntoine
Fix : sanitize PATH dir
c57e77e 
Actually comparaison between .krew/bin directory and path segment directory
is done with equal operator. This PR allow method filepath.Abs to be call during krew path creation
/internal/environment/environment.go#L43 and also in /cmd/krew/cmd/internal/setup_check.go#L62 path directory iteration
@RouxAntoine
Copy link
Contributor Author

RouxAntoine commented Nov 16, 2020 •
edited

/approve
I'll wait for you if you want to change the shadowing glitch that I lured you into. Please @ me.

thanks i fixed both now all seem good for me :) @corneliusweig

@RouxAntoine
Copy link
Contributor Author

As i am not sure if edited message with @ ping really ping the personne So i allow myself to ping again @corneliusweig (sorry if duplicate)

@corneliusweig
Copy link
Contributor

As i am not sure if edited message with @ ping really ping the personne So i allow myself to ping again @corneliusweig (sorry if duplicate)

I think it doesn't, I had the same problem before :)

Thanks again for looking into this!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig, RouxAntoine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7f53514 into kubernetes-sigs:master Nov 17, 2020
@RouxAntoine RouxAntoine deleted the fix/isbindirinpath-check branch November 17, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusweig corneliusweig corneliusweig left review comments

@ahmetb ahmetb Awaiting requested review from ahmetb

Assignees

@corneliusweig corneliusweig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitize path, before comparing with krew binary folder
3 participants
@RouxAntoine @k8s-ci-robot @corneliusweig