Default index function

[chriskim06]

Adding this based on the comment here #666 (comment). This reverts back constants.go so that it only has the constant values and adds a pkg/index/util.go that has the DefaultIndex function in it.

/assign @ahmetb
/assign @corneliusweig

Related issue: #637

[corneliusweig]

This is the right call to make constants really constant.

Looks all good, but you might want to adjust the date :)
/lgtm
/approve
/hold

[ahmetb]

a mini unit-test would be great for this.

[chriskim06]

for sure, I'll add that in

[ahmetb]

/approve

I'm now thinking if this option is worth documenting somewhere. We have other options like $KREW_ROOT that also are not documented, maybe in the future.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, chriskim06, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chriskim06]

I was planning on adding the docs in a separate PR but if you guys think we don't need it for now I can get to it later on

[corneliusweig]

If you don't forget about it, you can add the docs later. But we are in no hurry with this and it is far less useful while not documented.

[corneliusweig]

Suggested change

	t.Errorf("expected DefaultIndex() to be %q; got=%q", constants.DefaultIndexURI, got)
	t.Errorf("DefaultIndex() = %q, want %q", got, constants.DefaultIndexURI)

Same below.

[corneliusweig]

/lgtm
Release the hold of you want to do the documentation in a separate PR.

[chriskim06]

Ya I'd like to do them in a separate PR, I'll be able to submit that PR this weekend.

/hold cancel