Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support linux/arm64 release #689

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Support linux/arm64 release #689

merged 1 commit into from
Feb 5, 2021

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Feb 2, 2021

Fixes #673
Fixes #688

@ahmetb
Support arm64 releases
712261e 
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2021
@corneliusweig
Copy link
Contributor

/lgtm
/hold
For thoughts from @chriskim06

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2021
@chriskim06
Copy link
Member

This seems fine to me, I only see 2 plugins (passman and doctor) that would be affected by this I think. Should we file issues in their repos or something to let them know about this change?

@ahmetb
Copy link
Member Author

ahmetb commented Feb 5, 2021

This seems fine to me, I only see 2 plugins (passman and doctor) that would be affected by this I think. Should we file issues in their repos or something to let them know about this change?

Yeah sounds good, that would be great if you can open those issues.

I'll go ahead and merge this.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021
@ahmetb
Copy link
Member Author

ahmetb commented Feb 5, 2021 •
edited

/retitle Support linux/arm64 releases

@ahmetb ahmetb changed the title Support arm64 releases Support linux/arm64 release Feb 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7f6bb59 into kubernetes-sigs:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@corneliusweig corneliusweig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install: uses "arm" as arch selector on "arm64" devices Doesn't install on arm64
4 participants
@ahmetb @k8s-ci-robot @corneliusweig @chriskim06