-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ListIndexes treating file as index candidates #703
Conversation
Welcome @lauchokyip! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor naming improvement, otherwise LGTM
@@ -42,8 +42,11 @@ func ListIndexes(paths environment.Paths) ([]Index, error) { | |||
} | |||
|
|||
indexes := []Index{} | |||
for _, dir := range dirs { | |||
indexName := dir.Name() | |||
for _, file := range dirs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is confusing that dirs
does not contain directories but also files. Let's make this clear by renaming to entries
.
for _, file := range dirs { | |
for _, e := range entries { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will work on it now :)
@corneliusweig Fixed 👍🏼 |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusweig, lauchokyip The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #...#683
Related issue: #... ListIndexes treating file as index candidates