-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make fmt.FPrintln instead of klog while printing error message #719
Conversation
Welcome @developer-guy! |
ecbf2b7
to
d4a8ef5
Compare
As far as I understand, @developer-guy you agree that keeping |
@corneliusweig: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hi @corneliusweig, yes but just for printing the stack trace of the error like ahmetb said, fmt package would be ok for the other one. |
@corneliusweig how can I re-open it? |
/reopen |
@developer-guy: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@corneliusweig I think for the user-visible message at -v=0 we can print without klog. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, developer-guy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sorry for the ping @corneliusweig but can you please tell me what can I do for completing this issue? Because I think it is ready to merge, isn't it? |
/retest |
hack/run-integration-tests.sh is what's failing. Can be relevant since those tests check output. |
I think the tests are failing because fmt.Print does not cause the process to exit with a non-zero status code :) |
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
thank you so much, I added a new line to make it exit with a non-zero status code. |
/lgtm |
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Fixes #717
Related issue: #717
cc: @Dentrax @erkanzileli