-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect download failures when status code > 200 #820
detect download failures when status code > 200 #820
Conversation
Welcome @daniel-garcia! |
487f747
to
1ed8070
Compare
1ed8070
to
d724055
Compare
d724055
to
329d689
Compare
/lgtm |
Thanks for this patch, sorry it didn't catch my attention earlier. Can we also add a test case (with a httptest server responding with 404 ) to validate this doesn't regress? |
329d689
to
5a65f69
Compare
5a65f69
to
6a7d16f
Compare
done. |
6a7d16f
to
156876c
Compare
156876c
to
15c40b6
Compare
/lgtm |
Can we complete this if all okay ? We need this change, thank you |
/lgtm thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, ankishagarwal, daniel-garcia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
detect download failures when status code is > 200
#819