Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Add version options for kube-batch #490

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

jiaxuanzhou
Copy link
Contributor

@jiaxuanzhou jiaxuanzhou commented Dec 5, 2018

What this PR does / why we need it:

$ make 
mkdir -p _output/bin
go build  -ldflags " \
        -X 'github.com/kubernetes-sigs/kube-batch/pkg/version.GitSHA=`git rev-parse HEAD`' \
        -X 'github.com/kubernetes-sigs/kube-batch/pkg/version.Built=`date "+%Y-%m-%d %H:%M:%S"`'   \
        -X 'github.com/kubernetes-sigs/kube-batch/pkg/version.Version=v0.2'" \
        -o _output/bin/kube-batch ./cmd/kube-batch
$  _output/bin/kube-batch --version 
API Version: v1alpha1
Version: v0.2
Git SHA: aaf29293a165477afec79b77ea4b1cad3bac030e
Built At: 2018-12-05 16:12:54
Go Version: go1.11.1
Go OS/Arch: darwin/amd64

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2018
@jiaxuanzhou
Copy link
Contributor Author

/assign @k82cn

@k82cn
Copy link
Contributor

k82cn commented Dec 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2018
@k82cn
Copy link
Contributor

k82cn commented Dec 5, 2018

oh, make verify error; please help to fix it :)

@k82cn
Copy link
Contributor

k82cn commented Dec 5, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaxuanzhou, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 5, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 5, 2018
@k82cn
Copy link
Contributor

k82cn commented Dec 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit c4896a4 into kubernetes-retired:master Dec 5, 2018
@jiaxuanzhou jiaxuanzhou deleted the version branch December 5, 2018 13:09
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants