-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IgnoreErr
options from the Import/Export
function called via web API
#112
Remove IgnoreErr
options from the Import/Export
function called via web API
#112
Conversation
Hi @196Ikuchil. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sorry, this is my mistake.. |
65dcb9f
to
cdfecce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nice catch.
/lgtm
/approve
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 196Ikuchil, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
In #103, I have added the
IgnoreErr
option to theImport/Export
functions called via web API.But the
IgnoreErr
option was going to use for another logic (Only for Importing the existing Cluster's resources.)When we call it via web API, it should return an error if an error has occurred.
Since the current usage of the function is incorrect, I fixed it.
And also, I found a typo in the test function's name.
Which issue(s) this PR fixes:
Fixes #103
Special notes for your reviewer:
/label tide/merge-method-squash