support reset feature on web ui #114

sivchari · 2022-02-19T12:19:06Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

I add reset button to delete all resources and to reset scheduler configuration.
I update to server logic to do correct execution.

nil check at plugin package.
add GracePeriodOptions to force delete pods on node.

Which issue(s) this PR fixes:

Fixes #26

Special notes for your reviewer:

/label tide/merge-method-squash

k8s-ci-robot · 2022-02-19T12:19:14Z

Hi @sivchari. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sanposhiho · 2022-02-19T13:49:46Z

/ok-to-test

sanposhiho · 2022-02-19T13:51:51Z

/assign

sanposhiho · 2022-02-19T13:53:36Z

/retitle support reset feature on web ui

sanposhiho

Thanks for your effort @sivchari. Looks good overall.
Left few comments.

sanposhiho · 2022-02-19T13:54:59Z

pod/pod.go

-	if err := s.client.CoreV1().Pods(defaultNamespaceName).DeleteCollection(ctx, metav1.DeleteOptions{}, lopts); err != nil {
+	noGrace := int64(0)
+	if err := s.client.CoreV1().Pods(defaultNamespaceName).DeleteCollection(ctx, metav1.DeleteOptions{
+		GracePeriodSeconds: &noGrace,


Oops. Thanks for nice catch. Let's add the same doc as delete.

Suggested change

GracePeriodSeconds: &noGrace,

// need to use noGrace to avoid waiting kubelet checking.

// > When a force deletion is performed, the API server does not wait for confirmation from the kubelet that

// the Pod has been terminated on the node it was running on.

// https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination-forced

GracePeriodSeconds: &noGrace,

sanposhiho · 2022-02-19T13:55:36Z

web/components/ResetButton.vue

+<template>
+  <v-sheet class="transparent">
+    <v-btn color="primary ma-2" dark @click="reset()">
+      Reset Alll Resources</v-btn


Suggested change

Reset Alll Resources</v-btn

Reset All Resources</v-btn

sanposhiho · 2022-02-19T13:56:31Z

web/store/snackbar.ts

@@ -50,6 +50,11 @@ export default function snackbarStore() {
      this.setMessageType("error");
      this.open();
    },
+    setServerInfoMessage(message: string) {


sanposhiho · 2022-02-19T13:57:50Z

web/components/ResetButton.vue

@@ -0,0 +1,94 @@
+<template>
+  <v-sheet class="transparent">
+    <v-btn color="primary ma-2" dark @click="reset()">


Change it to the same color as Delete button on ResourceBar.

Suggested change

<v-btn color="primary ma-2" dark @click="reset()">

<v-btn color="error ma-2" dark @click="reset()">

sanposhiho · 2022-02-19T13:59:44Z

scheduler/plugin/plugins.go

@@ -92,6 +92,11 @@ func NewPluginConfig(pc []v1beta2.PluginConfig) ([]v1beta2.PluginConfig, error)
 	for i := range pc {
 		name := pc[i].Name
 		ret := pluginConfig[name].DeepCopy()
+		// If ret is nil, to reference ret.Object is occurred invalid memory address or nil pointer dereference.
+		// To avoid this error, if ret is nil, we continue to next loop.
+		if ret == nil {


Could you tell me how to get ret to be nil? I'd like to investigate it.

NewPluginConfig

for i := range pc { name := pc[i].Name klog.Info("plugin config: ", name) ret := pluginConfig[name].DeepCopy() // If ret is nil, to reference ret.Object is occurred invalid memory address or nil pointer dereference. // To avoid this error, if ret is nil, we continue to next loop. if ret == nil { continue } // v1beta2.PluginConfig may have data in pc[i].Args.Raw as []byte. // We have to encoding it in this case. if len(pc[i].Args.Raw) != 0 { // override default configuration if err := json.Unmarshal(pc[i].Args.Raw, &ret.Object); err != nil { return nil, err } } if pc[i].Args.Object != nil { // If data exists in both PluginConfig.Args.Raw and PluginConfig.Args.Object, // PluginConfig.Args.Raw would be ignored ret.Object = pc[i].Args.Object } pluginConfig[name] = ret }

Resource

One node and two pods on it, own unscheduled pod.
To reset all resources and reset scheduler configuration, I click reset button.
This behavior outputs as the following.

output

default plugin config: map[DefaultPreemption:&RawExtension{Raw:nil,} InterPodAffinity:&RawExtension{Raw:nil,} NodeAffinity:&RawExtension{Raw:nil,} NodeResourcesBalancedAllocation:&RawExtension{Raw:nil,} NodeResourcesFit:&RawExtension{Raw:nil,} PodTopologySpread:&RawExtension{Raw:nil,} VolumeBinding:&RawExtension{Raw:nil,}] /// snip 219 15:41:52.102498 1 plugins.go:95] plugin config: DefaultPreemption I0219 15:41:52.102583 1 plugins.go:95] plugin config: InterPodAffinity I0219 15:41:52.102646 1 plugins.go:95] plugin config: NodeAffinity I0219 15:41:52.102663 1 plugins.go:95] plugin config: NodeResourcesBalancedAllocation I0219 15:41:52.102725 1 plugins.go:95] plugin config: NodeResourcesFit I0219 15:41:52.102752 1 plugins.go:95] plugin config: PodTopologySpread I0219 15:41:52.102770 1 plugins.go:95] plugin config: VolumeBinding /// snip default plugin config: map[DefaultPreemption:&RawExtension{Raw:nil,} InterPodAffinity:&RawExtension{Raw:nil,} NodeAffinity:&RawExtension{Raw:nil,} NodeResourcesBalancedAllocation:&RawExtension{Raw:nil,} NodeResourcesFit:&RawExtension{Raw:nil,} PodTopologySpread:&RawExtension{Raw:nil,} VolumeBinding:&RawExtension{Raw:nil,}] /// snip I0219 15:42:31.684998 1 plugins.go:95] plugin config: DefaultPreemption I0219 15:42:31.685039 1 plugins.go:95] plugin config: InterPodAffinity I0219 15:42:31.685060 1 plugins.go:95] plugin config: NodeAffinity I0219 15:42:31.685084 1 plugins.go:95] plugin config: NodeResourcesBalancedAllocation I0219 15:42:31.685114 1 plugins.go:95] plugin config: NodeResourcesFit I0219 15:42:31.685523 1 plugins.go:95] plugin config: PodTopologySpread I0219 15:42:31.685557 1 plugins.go:95] plugin config: VolumeBinding I0219 15:42:31.685607 1 plugins.go:95] plugin config: NodeResourcesBalancedAllocationForSimulator I0219 15:42:31.685650 1 plugins.go:95] plugin config: InterPodAffinityForSimulator I0219 15:42:31.685675 1 plugins.go:95] plugin config: NodeResourcesFitForSimulator I0219 15:42:31.685698 1 plugins.go:95] plugin config: NodeAffinityForSimulator I0219 15:42:31.685731 1 plugins.go:95] plugin config: PodTopologySpreadForSimulator I0219 15:42:31.685756 1 plugins.go:95] plugin config: VolumeBindingForSimulator

If XXXForSimulator plugin calls DeepCopy(), return value is nil. So, ret.Object = pc.[i].Args.Object is occurred invalid memory address or nil pointer dereference.

If this change isn't existed, NewPluginConfig calls panic

goroutine 4069 [running]: net/http.(*conn).serve.func1(0xc00690fb80) /usr/local/go/src/net/http/server.go:1804 +0x153 panic(0x2807aa0, 0x43762a0) /usr/local/go/src/runtime/panic.go:971 +0x499 github.com/kubernetes-sigs/kube-scheduler-simulator/scheduler/plugin.NewPluginConfig(0xc005095880, 0xd, 0x10, 0x0, 0xd, 0x101, 0xc00b7c7c20, 0xc0039c7320) /go/src/simulator-server/scheduler/plugin/plugins.go:113 +0x2d8 github.com/kubernetes-sigs/kube-scheduler-simulator/scheduler.convertConfigurationForSimulator(0xc0004ce360, 0xc0048c37a0, 0xc006423b80, 0x3063ae8) /go/src/simulator-server/scheduler/scheduler.go:151 +0x16e github.com/kubernetes-sigs/kube-scheduler-simulator/scheduler.(*Service).StartScheduler(0xc00643d6e0, 0xc0004ce360, 0x4c11ac, 0x3031910) /go/src/simulator-server/scheduler/scheduler.go:73 +0x270 github.com/kubernetes-sigs/kube-scheduler-simulator/scheduler.(*Service).RestartScheduler(0xc00643d6e0, 0xc0004ce360, 0x2496bff, 0xc00b745e38) /go/src/simulator-server/scheduler/scheduler.go:43 +0x6c github.com/kubernetes-sigs/kube-scheduler-simulator/scheduler.(*Service).ResetScheduler(0xc00643d6e0, 0x0, 0x0) /go/src/simulator-server/scheduler/scheduler.go:55 +0x34 github.com/kubernetes-sigs/kube-scheduler-simulator/reset.(*Service).Reset(0xc00643d740, 0x3031910, 0xc00647b000, 0x10, 0x10) /go/src/simulator-server/reset/reset.go:58 +0x28e github.com/kubernetes-sigs/kube-scheduler-simulator/server/handler.(*ResetHandler).Reset(0xc0052a1c00, 0x306e158, 0xc006562140, 0x1829846755732203, 0xc000111400) /go/src/simulator-server/server/handler/reset.go:24 +0x8c github.com/labstack/echo/v4.(*Echo).add.func1(0x306e158, 0xc006562140, 0x2bcc949, 0x20) /go/pkg/mod/github.com/labstack/echo/v4@v4.5.0/echo.go:544 +0x62 github.com/labstack/echo/v4/middleware.CORSWithConfig.func1.1(0x306e158, 0xc006562140, 0x43a88a0, 0x203002) /go/pkg/mod/github.com/labstack/echo/v4@v4.5.0/middleware/cors.go:186 +0x1016 github.com/labstack/echo/v4/middleware.LoggerWithConfig.func2.1(0x306e158, 0xc006562140, 0x0, 0x0) /go/pkg/mod/github.com/labstack/echo/v4@v4.5.0/middleware/logger.go:117 +0x12c github.com/labstack/echo/v4.(*Echo).ServeHTTP(0xc0074ebb00, 0x302da28, 0xc00c17d960, 0xc0066c9900) /go/pkg/mod/github.com/labstack/echo/v4@v4.5.0/echo.go:654 +0x2bc net/http.serverHandler.ServeHTTP(0xc00c49f420, 0x302da28, 0xc00c17d960, 0xc0066c9900) /usr/local/go/src/net/http/server.go:2867 +0xa3 net/http.(*conn).serve(0xc00690fb80, 0x30319b8, 0xc00647af40) /usr/local/go/src/net/http/server.go:1932 +0x8cd created by net/http.(*Server).Serve /usr/local/go/src/net/http/server.go:2993 +0x39b

Okay. I think there is another issue.
Could you change NewSchedulerService like this? This initialSchedulerCfg field should not be change, but is changing actually because it's pointer and passed without deepcopy. It's definitely a bug.
(It is not needed to revert your change on NewPluginConfig.)

// NewSchedulerService starts scheduler and return *Service. func NewSchedulerService(client clientset.Interface, restclientCfg *restclient.Config, initialSchedulerCfg *v1beta2config.KubeSchedulerConfiguration) *Service { iniCfg := initialSchedulerCfg.DeepCopy() return &Service{clientset: client, restclientCfg: restclientCfg, initialSchedulerCfg: iniCfg} }

👍

I fixed it.

sanposhiho · 2022-02-19T14:20:44Z

web/pages/index.vue

+                    <ResourceBar />
+                    <SchedulerConfigurationEditButton />
+                    <ResourceAddButton />
+                    <ResetButton />


For the position of reset button, I prefer to place it next to import/export button.
So, let's wait for #81 and place it on the topbar. I think #81 is about to merge.

OK!, I wait it.

@sivchari
We merged #81.

sivchari · 2022-02-19T16:03:19Z

I fixed codes of your suggestion. A position of reset button haven't changed, yet.

sanposhiho

Thanks for addressing my reviews.
Added two comments 🙏

sanposhiho · 2022-02-19T16:59:15Z

web/components/ResetButton.vue

@@ -0,0 +1,92 @@
+<template>
+  <v-sheet class="transparent">
+    <v-btn color="error ma-2" dark @click="reset()"> Reset All Resources</v-btn>


This will reset scheduler config as well (not only resources)

Suggested change

<v-btn color="error ma-2" dark @click="reset()"> Reset All Resources</v-btn>

<v-btn color="error ma-2" dark @click="reset()"> Reset </v-btn>

sanposhiho · 2022-02-19T17:00:41Z

web/components/ResetButton.vue

+  </v-sheet>
+</template>
+
+<script lang="ts">


Could you change this component to behave like delete button on ResourceBar? You can refer to the implementation of that.

I think the dialog is needed:

not to reset mistakenly.

to tell users that this reset will also reset the scheduler settings.
https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/web/components/ResourceBar/DeleteButton.vue

sivchari · 2022-02-26T19:22:42Z

#81 is merged, so I’ll fix thix PR

sivchari · 2022-02-27T17:30:26Z

@sanposhiho
I fixed it.

sanposhiho · 2022-02-27T23:36:43Z

web/components/TopBar/ResetButton.vue

+
+    <v-card>
+      <v-card-title class="2">
+        Are you sure to reset all resources and scheduler configuration ?


Suggested change

Are you sure to reset all resources and scheduler configuration ?

Are you sure to reset all resources and scheduler configuration?

sanposhiho · 2022-02-27T23:40:21Z

web/components/TopBar/ResetButton.vue

+<template>
+  <v-dialog v-model="data.dialog" width="500">
+    <template #activator="{ on }">
+      <v-btn class="ma-5 mb-0" color="error" v-on="on"> Reset </v-btn>


Not aligned in position.

Suggested change

<v-btn class="ma-5 mb-0" color="error" v-on="on"> Reset </v-btn>

<v-btn class="ma-2" color="error" v-on="on"> Reset </v-btn>

sanposhiho

@sivchari Thanks for nice work!

/lgtm
/approve

k8s-ci-robot · 2022-02-28T02:33:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, sivchari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sanposhiho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* fix nil pointer reference * update delete collection method to force delete * fix conflict * delete debug print * fix lint * fix * update factory method * add provider * fix reset button * fix format

…in (#121) * Able to configure API server and port, thus expose it is possible via compose * linters * update property name to be more descriptive * change the parameter arg to be more descriptive * WIP - use create server chain to start k8s api server. * WIP - remove unecessary shutdown fn * setup annoymoususer for insecure testing * update go mod sum * instead of building kube-api , only do openapi-gen * add vendor files into repo and keep existing openapi gen * forgot to add openapi * remove not needed generated api * refactor due to linters * change makefile to what it was for github action * refactor due to cyclomatic complexity * use original dockerfile step * unnecessary if * remove openapi step before test * disable admission plugins to for node taints and service account checks * Added docs to describe our kube-apiserver creation process and env var * add permission doc * Import from existing cluster (#111) * feat:add ignoreRestart Option to Import on ExportService * add:impl ReplicateExistingClusterService * add:ExternalKubeClientCfg to config * add:impl interface of ReplicateExistingClusterService * feat:impl replicate existing cluster's resources logic if ExternalImportEnabled is enabled * test:add Import with ignoreRestart test * refactor:add interface of ExportService * add:create mock of ExportService(run go generate) * Update config/config.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update export/export.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update export/export.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update replicateexistingcluster/replicateexistingcluster.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update replicateexistingcluster/replicateexistingcluster.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update server/di/di.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update server/di/di.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update replicateexistingcluster/replicateexistingcluster.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update replicateexistingcluster/replicateexistingcluster.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Update replicateexistingcluster/replicateexistingcluster.go Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * refactor:rename IgnoreRestart option to IgnoreSchedulerConfiguration * refactor:rename _exportService to exportService * refactor:rename to replicateExistingClusterService * refactor:change convert logic of resources * refactor:move private functions to utils.go of export package * test:export utils test * test:add test for replicateexistingcluster * fix:return value of ConvertToResourcesForImportFromResourcesForExport * fix:get a context in arg of ImportFromExistingCluster * fix:remove comment * fix:rename to ConvertResourcesForImportToResourcesForExport * fix:do import before API server starting Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * support reset feature on web ui (#114) * fix nil pointer reference * update delete collection method to force delete * fix conflict * delete debug print * fix lint * fix * update factory method * add provider * fix reset button * fix format * Rename simulatorPlugin to wrappedPlugin (#126) * refactor:rename simulatorPlugin to wrappedPlugin * fix:prefix word * test:fix * refactor:receiver name * Implement table view on Web UI (#119) * refactor:move resource view components to under the ResourceViews/List/ directory * refactor:create ResourcesViewPanel component and replace it on index.vue * add: ResourcesViewPanel & RadioButton to select view * add:DataTable template * fix:typo * add:basic data tables for each resources * fix:import PodList on UnscheduledPodList * fix:change display columns * fix:declare of Array type * fix:remove debug comment * fix:change show columns * fix:change columns name * typo:lang * style:adjust search text field of tables * feat:add ALPHA_TABLE_VIEWS env * fix:show datatable if ALPHA_TABLE_VIEWS env val is "1" * fix:column name * refactor:separated into new component * refactor:change label to title * style:make it clear that each row on table is clickable * Display the kind/apiVersion in the scheduler configuration yaml (#129) * Display the kind/apiVersion in the scheduler configuration yaml * Add kind/apiVersion to the yaml as you might expect * For "APPLY" keep the profiles only so that ignored edits (e.g. apiVersion) are not displayed next time. * The editor still allows unsupported/ignored edits, but at least it is clear what was set when you revisit. Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com> * Ensure only profiles get updated in ApplySchedulerConfig * Also don't yarn lint/format coverage directory * WIP - remove unecessary shutdown fn * fix rebase issue * merge master * Request kube apiserver directly from frontend (#115) * Request kube apiserver directly from frontend * Show axios errors on page * Add axios error judge * Change default kubeAPIserver port * Add simple cause err message, Fix typo * Delete comments * Fix err message * change kube apiserver request header * tmp * Delete pods when delete node * delete managed field before apply * Update web/components/ResourceBar/ResourceBar.vue Co-authored-by: Kensei Nakada <handbomusic@gmail.com> Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Add deprecate description (#127) * Add deprecate comment lines * change some docs description * fix indent and move not-deprecate APIs * fix linter err * setup annoymoususer for insecure testing * Request kube apiserver directly from frontend (#115) * Request kube apiserver directly from frontend * Show axios errors on page * Add axios error judge * Change default kubeAPIserver port * Add simple cause err message, Fix typo * Delete comments * Fix err message * change kube apiserver request header * tmp * Delete pods when delete node * delete managed field before apply * Update web/components/ResourceBar/ResourceBar.vue Co-authored-by: Kensei Nakada <handbomusic@gmail.com> Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Able to configure API server and port, thus expose it is possible via compose * refactor due to linters * remove unecessary error channel * log the error return from prepared aggregator server * add temp cert directory * remote unnecessary changes. * update md to reflect default api behavior * remove unnecessary flag * Enable Priority Plugin for admission Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * Change the order of logging to ensure url is correct. Co-authored-by: Kensei Nakada <handbomusic@gmail.com> * pass cleanupFunc all the way to shutdown * attemp to fix useragent issue * Revert "attemp to fix useragent issue" This reverts commit b06408a. Co-authored-by: 196Ikuchil <22634362+196Ikuchil@users.noreply.github.com> Co-authored-by: Kensei Nakada <handbomusic@gmail.com> Co-authored-by: sivchari <shibuuuu5@gmail.com> Co-authored-by: Mark Sturdevant <mark.sturdevant@ibm.com> Co-authored-by: momom-i <51011095+momom-i@users.noreply.github.com>

k8s-ci-robot requested review from alculquicondor and Huang-Wei February 19, 2022 12:19

k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 19, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2022

k8s-ci-robot assigned sanposhiho Feb 19, 2022

k8s-ci-robot changed the title ~~Featur add reset button~~ support reset feature on web ui Feb 19, 2022

sanposhiho reviewed Feb 19, 2022

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2022

sivchari added 8 commits February 28, 2022 01:39

fix nil pointer reference

7232b7f

update delete collection method to force delete

303f286

fix conflict

825bfff

delete debug print

96b7998

fix lint

7a3e02d

fix

07ccaec

update factory method

9ad3ae1

add provider

1b9b3b7

fix reset button

503d4a6

sivchari force-pushed the featur-add-reset-button branch from 0d38cfd to 503d4a6 Compare February 27, 2022 17:29

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2022

sanposhiho reviewed Feb 27, 2022

View reviewed changes

fix format

1677a61

sanposhiho approved these changes Feb 28, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022

k8s-ci-robot merged commit 9893baf into kubernetes-sigs:master Feb 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support reset feature on web ui #114

support reset feature on web ui #114

sivchari commented Feb 19, 2022 •

edited

Loading

k8s-ci-robot commented Feb 19, 2022

sanposhiho commented Feb 19, 2022

sanposhiho commented Feb 19, 2022

sanposhiho commented Feb 19, 2022

sanposhiho left a comment

sanposhiho Feb 19, 2022

sanposhiho Feb 19, 2022

sanposhiho Feb 19, 2022

sanposhiho Feb 19, 2022

sanposhiho Feb 19, 2022

sivchari Feb 19, 2022

sanposhiho Feb 19, 2022 •

edited

Loading

sivchari Feb 19, 2022

sanposhiho Feb 19, 2022

sivchari Feb 19, 2022

sanposhiho Feb 26, 2022

sivchari commented Feb 19, 2022 •

edited

Loading

sanposhiho left a comment

sanposhiho Feb 19, 2022 •

edited

Loading

sanposhiho Feb 19, 2022

sivchari commented Feb 26, 2022 •

edited

Loading

sivchari commented Feb 27, 2022 •

edited

Loading

sanposhiho Feb 27, 2022

sanposhiho Feb 27, 2022 •

edited

Loading

sanposhiho left a comment

k8s-ci-robot commented Feb 28, 2022

-		GracePeriodSeconds: &noGrace,
+		// need to use noGrace to avoid waiting kubelet checking.
+		// > When a force deletion is performed, the API server does not wait for confirmation from the kubelet that
+		//   the Pod has been terminated on the node it was running on.
+		// https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination-forced
+		GracePeriodSeconds: &noGrace,

	<v-btn color="primary ma-2" dark @click="reset()">
	<v-btn color="error ma-2" dark @click="reset()">

	Are you sure to reset all resources and scheduler configuration ?
	Are you sure to reset all resources and scheduler configuration?

	<v-btn class="ma-5 mb-0" color="error" v-on="on"> Reset </v-btn>
	<v-btn class="ma-2" color="error" v-on="on"> Reset </v-btn>

support reset feature on web ui #114

support reset feature on web ui #114

Conversation

sivchari commented Feb 19, 2022 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

k8s-ci-robot commented Feb 19, 2022

sanposhiho commented Feb 19, 2022

sanposhiho commented Feb 19, 2022

sanposhiho commented Feb 19, 2022

sanposhiho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Resource

output

sanposhiho Feb 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sivchari commented Feb 19, 2022 • edited Loading

sanposhiho left a comment

Choose a reason for hiding this comment

sanposhiho Feb 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sivchari commented Feb 26, 2022 • edited Loading

sivchari commented Feb 27, 2022 • edited Loading

Choose a reason for hiding this comment

sanposhiho Feb 27, 2022 • edited Loading

Choose a reason for hiding this comment

sanposhiho left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 28, 2022

sivchari commented Feb 19, 2022 •

edited

Loading

sanposhiho Feb 19, 2022 •

edited

Loading

sivchari commented Feb 19, 2022 •

edited

Loading

sanposhiho Feb 19, 2022 •

edited

Loading

sivchari commented Feb 26, 2022 •

edited

Loading

sivchari commented Feb 27, 2022 •

edited

Loading

sanposhiho Feb 27, 2022 •

edited

Loading