Expand simulator plugin to allow arbitrary processing before/after execution of `Filter`, `Score` and `NormalizeScore` #128

196Ikuchil · 2022-03-02T17:17:41Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

We expand this simulator plugin to allow arbitrary processing before/after execution of Filter, Score and NormalizeScore.
Implement WithPluginNameOption that allows us to name these plugins.
Implement WithWeightOption that allows us to set plugin weight by this option.

Which issue(s) this PR fixes:

Fixes #125

Special notes for your reviewer:

/label tide/merge-method-squash

k8s-ci-robot · 2022-03-02T17:17:50Z

Hi @196Ikuchil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

196Ikuchil · 2022-03-03T15:57:24Z

@sanposhiho
We have changed course significantly since yesterday's check.
And since this PR had some conflicts, I did force-push.

The current changes are

Move the wrappedplugin to new wrappledplugin.go.
Implement three interfaces in wrappledplugin.go.
Insert these into the logic.
Insert storing process of these results.
Run go generate.

196Ikuchil · 2022-03-03T16:01:38Z

scheduler/plugin/mock/wrappedplugin.go

+}
+
+// apply mocks base method
+func (m *MockOption) apply(arg0 *options) {


~~I ran~~

//go:generate mockgen -destination=./mock/$GOFILE -source=$GOFILE store, filterPluginExtender, scorePluginExtender, normalizeScorePluginExtender

~~https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/128/files#diff-88e5e83973b677bd5a4adc7d8450d0981ba9d1a6a69db4f84bbc67ee6bdb2492R12~~

~~I think my implementation way is not good. Could you give me some advice?~~

Maybe resolve. Fix it tonight.

196Ikuchil · 2022-03-05T03:37:31Z

/assign @sanposhiho

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

sanposhiho

Thanks. Some small nits.

scheduler/plugin/wrappedplugin.go

sanposhiho · 2022-04-24T04:33:34Z

scheduler/plugin/wrappedplugin.go

+
+func WithExtendersOption(opt *Extenders) Option {
+	return extendersOption(*opt)
+}
+
+func WithPluginNameOption(opt *string) Option {
+	return pluginNameOption(*opt)
+}
+
+func WithWeightOption(opt *int32) Option {
+	return weightOption(*opt)
+}


Could you add brief explanations for each options?

Thanks for the reviews!
I added new comments for these options.

scheduler/plugin/wrappedplugin_test.go

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

sanposhiho

small nits

scheduler/plugin/wrappedplugin.go

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

196Ikuchil · 2022-05-10T12:04:15Z

@sanposhiho Fixed✋

sanposhiho

Nice work 🎉
/lgtm
/approve

k8s-ci-robot · 2022-05-10T14:48:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 196Ikuchil, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sanposhiho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested a review from alculquicondor March 2, 2022 17:17

k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Mar 2, 2022

k8s-ci-robot requested a review from sanposhiho March 2, 2022 17:17

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 2, 2022

196Ikuchil force-pushed the ace_plugins branch from f2f4faf to b94ea25 Compare March 3, 2022 15:49

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 3, 2022

196Ikuchil commented Mar 3, 2022

View reviewed changes

196Ikuchil force-pushed the ace_plugins branch from 6e516ef to 49cc15a Compare March 4, 2022 09:22

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 4, 2022

196Ikuchil added 3 commits March 5, 2022 01:40

feat:create warppedplugin.go file and move the struct to it

d43b636

test:run go generate mockgen

e51fea8

test:refactor and add filter&score test

598d3b0

196Ikuchil force-pushed the ace_plugins branch from b99ad8b to 598d3b0 Compare March 4, 2022 16:43

196Ikuchil added 2 commits March 5, 2022 12:06

refactor:arg name

2d996d3

test:before/after NormalizeScore

ac71f90

196Ikuchil changed the title ~~[WIP]Expand simulator plugin to allow arbitrary processing before/after execution of Filter, Score and NormalizeScore~~ Expand simulator plugin to allow arbitrary processing before/after execution of Filter, Score and NormalizeScore Mar 5, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2022

k8s-ci-robot assigned sanposhiho Mar 5, 2022

196Ikuchil and others added 12 commits April 18, 2022 18:12

Update scheduler/plugin/wrappedplugin.go

c1c710f

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

8c7fa27

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

fde9595

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

8f378c6

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

7b86aae

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

fix:remove ``

8e04159

fix:rename exposed function & test

16ca660

docs:fix some commnets

b1f68a8

feat:WithPluginNameOption

e326e70

feat:weightOption

de35c45

test:fix&add WithWeightOption test case

8f6eeb9

test:fix&add test case of NewWrappedPlugin_WithPluginNameOption

63bcfb1

sanposhiho reviewed Apr 24, 2022

View reviewed changes

196Ikuchil and others added 7 commits April 30, 2022 14:46

Update scheduler/plugin/wrappedplugin.go

bdb4d17

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

d2a1234

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

388adb5

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin_test.go

5abaa00

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

b88740d

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

4311f0f

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

docs:add some comments for options function

0f8323f

sanposhiho reviewed May 9, 2022

View reviewed changes

scheduler/plugin/wrappedplugin.go Outdated Show resolved Hide resolved

scheduler/plugin/wrappedplugin.go Show resolved Hide resolved

196Ikuchil and others added 3 commits May 10, 2022 20:30

Update scheduler/plugin/wrappedplugin.go

d1376bd

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

Update scheduler/plugin/wrappedplugin.go

c8d4bca

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>

fix:some comments

8f56dce

sanposhiho approved these changes May 10, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022

k8s-ci-robot merged commit a7c02e4 into kubernetes-sigs:master May 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand simulator plugin to allow arbitrary processing before/after execution of `Filter`, `Score` and `NormalizeScore` #128

Expand simulator plugin to allow arbitrary processing before/after execution of `Filter`, `Score` and `NormalizeScore` #128

196Ikuchil commented Mar 2, 2022 •

edited

Loading

k8s-ci-robot commented Mar 2, 2022

196Ikuchil commented Mar 3, 2022 •

edited

Loading

196Ikuchil Mar 3, 2022 •

edited

Loading

196Ikuchil Mar 4, 2022

196Ikuchil commented Mar 5, 2022

sanposhiho left a comment

sanposhiho Apr 24, 2022

196Ikuchil Apr 30, 2022

sanposhiho left a comment

196Ikuchil commented May 10, 2022

sanposhiho left a comment

k8s-ci-robot commented May 10, 2022

Expand simulator plugin to allow arbitrary processing before/after execution of Filter, Score and NormalizeScore #128

Expand simulator plugin to allow arbitrary processing before/after execution of Filter, Score and NormalizeScore #128

Conversation

196Ikuchil commented Mar 2, 2022 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

k8s-ci-robot commented Mar 2, 2022

196Ikuchil commented Mar 3, 2022 • edited Loading

196Ikuchil Mar 3, 2022 • edited Loading

Choose a reason for hiding this comment

196Ikuchil Mar 4, 2022

Choose a reason for hiding this comment

196Ikuchil commented Mar 5, 2022

sanposhiho left a comment

Choose a reason for hiding this comment

sanposhiho Apr 24, 2022

Choose a reason for hiding this comment

196Ikuchil Apr 30, 2022

Choose a reason for hiding this comment

sanposhiho left a comment

Choose a reason for hiding this comment

196Ikuchil commented May 10, 2022

sanposhiho left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 10, 2022

Expand simulator plugin to allow arbitrary processing before/after execution of `Filter`, `Score` and `NormalizeScore` #128

Expand simulator plugin to allow arbitrary processing before/after execution of `Filter`, `Score` and `NormalizeScore` #128

196Ikuchil commented Mar 2, 2022 •

edited

Loading

196Ikuchil commented Mar 3, 2022 •

edited

Loading

196Ikuchil Mar 3, 2022 •

edited

Loading