Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed how to specify the namespace in Reset function for resources with a namespace #162

Merged
merged 5 commits into from
May 10, 2022
Merged

Fixed how to specify the namespace in Reset function for resources with a namespace #162

merged 5 commits into from
May 10, 2022

Conversation

196Ikuchil
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixed how to specify the namespace in Reset function for resources with a namespace.
The current Reset function can't work correctly.
I'm so sorry, this is caused by my fixing of #116.

Which issue(s) this PR fixes:

Relates #84, #116

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2022
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 6, 2022
@k8s-ci-robot k8s-ci-robot requested a review from Huang-Wei May 6, 2022 14:06
@196Ikuchil
Copy link
Contributor Author

This fix will work correctly in the default namespace.
Other namespaces continue to have bugs in their behavior. See also #84.

/assign @sanposhiho

@196Ikuchil 196Ikuchil mentioned this pull request May 6, 2022
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2022
@196Ikuchil 196Ikuchil mentioned this pull request May 7, 2022
Merged
sanposhiho
sanposhiho reviewed May 9, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small nits

node/node.go Outdated Show resolved Hide resolved
node/node.go Outdated Show resolved Hide resolved
@196Ikuchil
Copy link
Contributor Author

@sanposhiho updated/

sanposhiho
sanposhiho reviewed May 10, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 196Ikuchil, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 85c8ac2 into kubernetes-sigs:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@196Ikuchil @k8s-ci-robot @sanposhiho