Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): modify wrong version on go.mod #292

Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix(deps): modify wrong version on go.mod #292

merged 1 commit into from
Apr 26, 2023

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Apr 26, 2023 •
edited
Loading

What type of PR is this?

/area simulator
/kind bug

What this PR does / why we need it:

We cannot import the simulator from the external repository due to the wrong version in go.mod.
We didn't notice it so far because we use replace in go.mod. 😓 So, it's only the bug happening when we try to import the simulator from external repo.

Which issue(s) this PR fixes:

Fixes #296

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added area/simulator Issues or PRs related to the simulator. kind/bug Categorizes issue or PR as related to a bug. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from 196Ikuchil April 26, 2023 00:34
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Apr 26, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@sanposhiho
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2023
@sanposhiho sanposhiho mentioned this pull request Apr 26, 2023
Closed
2 tasks
@196Ikuchil
Copy link
Contributor

🙇
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3dad850 into kubernetes-sigs:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@196Ikuchil 196Ikuchil Awaiting requested review from 196Ikuchil

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@196Ikuchil 196Ikuchil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/simulator Issues or PRs related to the simulator. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the simulator cannot be imported from other golang modules
3 participants
@sanposhiho @k8s-ci-robot @196Ikuchil