Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 196Ikuchil to approvers #299

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

196Ikuchil
Copy link
Contributor

@196Ikuchil 196Ikuchil commented Apr 28, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adding new sig member @196Ikuchil as an approver for this repository.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @sanposhiho
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Apr 28, 2023
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2023
@196Ikuchil
Copy link
Contributor Author

/retitle Add 196Ikuchil to approvers

@k8s-ci-robot k8s-ci-robot changed the title add new reviewr Add 196Ikuchil to approvers Apr 28, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
@sanposhiho
Copy link
Member

sanposhiho commented Apr 28, 2023

@196Ikuchil is the most powerful contributor in the simulator, definitely, we cannot achieve the first release without him.
+100 from me. Thanks for your incredible contributions so far. And I am looking forward to continuing working with you here.

/lgtm
leave /approval to other approvers. @alculquicondor @Huang-Wei

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@sanposhiho
Copy link
Member

/assign @Huang-Wei @alculquicondor

@alculquicondor
Copy link
Contributor

+1

I haven't personally worked with @196Ikuchil, but I've notice the numerous contributions.

@Huang-Wei
Copy link

/approve

Thanks @196Ikuchil for the continuous contributions!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 196Ikuchil, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit f9b87d7 into kubernetes-sigs:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants