Config: add new lint rule duplicated-imports #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
approved
sanposhiho
reviewed
Jun 24, 2023
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 196Ikuchil, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
|
/retest |
1 similar comment
|
/retest |
|
The lint job is really flaky. Opened kubernetes/test-infra#30364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area simulator
What this PR does / why we need it:
Thanks to #306, I noticed that it is possible to import the same package in a file.
So, add a rule to linter to make it detectable.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
To pass the test, we wait for #306 to be merged.
/hold
/label tide/merge-method-squash