-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace api/v1/namespaces//pods with api/v1/pods #313
Replace api/v1/namespaces//pods with api/v1/pods #313
Conversation
Welcome @Lan-ce-lot! |
Hi @Lan-ce-lot. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Lancelot <1984737645@qq.com>
8caa12a
to
097d49a
Compare
/ok-to-test |
/assign |
/kind bug |
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Lan-ce-lot, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area web
What this PR does / why we need it:
I am trying to integrate kube-scheduler-simulator with a real Kubernetes cluster. And I found the correct API to retrieve all pods is api/v1/pods instead of api/v1/namespaces//pods in some versions of kube-apiserver.
So i thinks replacement
api/v1/namespaces//pods
withapi/v1/pods
is a good way.Which issue(s) this PR fixes:
Fixes #312 #290
Special notes for your reviewer:
/label tide/merge-method-squash