Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extender on debuggable scheduler #358

Merged
merged 7 commits into from
Jul 22, 2024
Merged

Support extender on debuggable scheduler #358

merged 7 commits into from
Jul 22, 2024

Conversation

YamasouA
Copy link
Contributor

@YamasouA YamasouA commented Jun 29, 2024 •
edited
Loading

What type of PR is this?

/area simulator
/kind feature

What this PR does / why we need it:

This PR is support extender on debuggable scheduler.

Which issue(s) this PR fixes:

Fixes #291

Special notes for your reviewer:

This PR was created by cherry-picking from #321 .

/assign @sanposhiho

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added area/simulator Issues or PRs related to the simulator. kind/feature Categorizes issue or PR as related to a new feature. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jun 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @YamasouA. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2024
@YamasouA YamasouA changed the title Support extender on external scheduler [Cherry Pick] Support extender on debuggable scheduler Jun 29, 2024
sanposhiho
sanposhiho reviewed Jun 29, 2024
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2024
@YamasouA
Copy link
Contributor Author

/retest

@sanposhiho sanposhiho mentioned this pull request Jun 30, 2024
Closed
sanposhiho
sanposhiho reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is LGTM, but we lack the documentation.
It feels like we need to evolve https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/simulator/docs/extender.md.

Can you renovate the page with a simple step-by-step tutorial how we can use this extender feature?

We can use this extender example as an implementation:
https://github.com/everpeace/k8s-scheduler-extender-example

And, the tutorial would be:

  1. Run k8s-scheduler-extender-example in local
  2. Run Kwok and run the debuggable scheduler with an extender enabled.
  3. Create a Pod and see if the extender's result is actually shown in Pod's annotation.

@sanposhiho
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, YamasouA

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit b9ec419 into kubernetes-sigs:master Jul 22, 2024
5 checks passed
@sanposhiho sanposhiho mentioned this pull request Aug 3, 2024
Closed
YamasouA added a commit to YamasouA/kube-scheduler-simulator that referenced this pull request Aug 10, 2024
@YamasouA @196Ikuchil
Support extender on debuggable scheduler (kubernetes-sigs#358)
3616f28 
* use --config flag instead of KUBECONFIG

* fix conflict

* refactor:improve comment

* fix:typo

* fix:lint

* Revert "use --config flag instead of KUBECONFIG"

This reverts commit 3048c56.

* fix lint

---------

Co-authored-by: 196Ikuchil <196Ikuchil@gmail.com>
YamasouA added a commit to YamasouA/kube-scheduler-simulator that referenced this pull request Aug 30, 2024
@YamasouA @196Ikuchil
Support extender on debuggable scheduler (kubernetes-sigs#358)
e770a11 
* use --config flag instead of KUBECONFIG

* fix conflict

* refactor:improve comment

* fix:typo

* fix:lint

* Revert "use --config flag instead of KUBECONFIG"

This reverts commit 3048c56.

* fix lint

---------

Co-authored-by: 196Ikuchil <196Ikuchil@gmail.com>
YamasouA added a commit to YamasouA/kube-scheduler-simulator that referenced this pull request Sep 15, 2024
@YamasouA @196Ikuchil
Support extender on debuggable scheduler (kubernetes-sigs#358)
a234567 
* use --config flag instead of KUBECONFIG

* fix conflict

* refactor:improve comment

* fix:typo

* fix:lint

* Revert "use --config flag instead of KUBECONFIG"

This reverts commit 3048c56.

* fix lint

---------

Co-authored-by: 196Ikuchil <196Ikuchil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@196Ikuchil 196Ikuchil Awaiting requested review from 196Ikuchil

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/simulator Issues or PRs related to the simulator. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support Scheduler Extender in the external scheduler
4 participants
@YamasouA @k8s-ci-robot @sanposhiho @196Ikuchil