Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https instead of ssh for submodule #40

Merged

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Nov 5, 2021

Jobs post-kube-scheduler-simulator-push were failed.
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kube-scheduler-simulator-push-images/1456617270737375232

error log:

$ git submodule update --init --recursive
Submodule 'submodules/kubernetes' (git@github.com:kubernetes/kubernetes.git) registered for path 'submodules/kubernetes'
Cloning into '/home/prow/go/src/github.com/kubernetes-sigs/kube-scheduler-simulator/submodules/kubernetes'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:kubernetes/kubernetes.git' into submodule path '/home/prow/go/src/github.com/kubernetes-sigs/kube-scheduler-simulator/submodules/kubernetes' failed
Failed to clone 'submodules/kubernetes'. Retry scheduled
Cloning into '/home/prow/go/src/github.com/kubernetes-sigs/kube-scheduler-simulator/submodules/kubernetes'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:kubernetes/kubernetes.git' into submodule path '/home/prow/go/src/github.com/kubernetes-sigs/kube-scheduler-simulator/submodules/kubernetes' failed
Failed to clone 'submodules/kubernetes' a second time, aborting
# Error: exit status 1

I also asked it on test-infra: kubernetes/test-infra#24268

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2021
@sanposhiho
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2021
@sanposhiho
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 30, 2021
@Huang-Wei
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@sanposhiho
Copy link
Member Author

/approve

Let's check if job works or not with this change.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 164026d into kubernetes-sigs:master Dec 7, 2021
@sanposhiho
Copy link
Member Author

sanposhiho commented Dec 7, 2021

Nice, error log is changed.

Running...
$ARTIFACTS is set, sending logs to /logs/artifacts
2021/12/07 04:41:43 Build directory: .
2021/12/07 04:41:43 /home/prow/go/src/github.com/kubernetes-sigs/kube-scheduler-simulator/cloudbuild.yaml does not exist

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kube-scheduler-simulator-push-images/1468077827424260096

This error is Okay. We'll create cloudbuild.yaml in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants