Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to reflect the addition of PriorityClass #69

Closed
wants to merge 1 commit into from
Closed

Update README.md to reflect the addition of PriorityClass #69

wants to merge 1 commit into from

Conversation

khalilswdp
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updated the image on README.md to include PriorityClass, as well as added PriorityClass as a resource that we can simulate.

Which issue(s) this PR fixes:

This PR is related to #27

Special notes for your reviewer:

If there are other changes that I need to make, please tell me and I'll do them.

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2021
@khalilswdp
Copy link
Contributor Author

/assign @alculquicondor

@khalilswdp khalilswdp force-pushed the documentation/27-documentation branch from 36637fa to a7526b6 Compare December 20, 2021 11:35
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: khalilswdp
To complete the pull request process, please ask for approval from alculquicondor after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2021
@sanposhiho
Copy link
Member

This PR should be merged after #53.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2021
@khalilswdp khalilswdp closed this Dec 20, 2021
@khalilswdp khalilswdp deleted the documentation/27-documentation branch December 20, 2021 11:38
@khalilswdp
Copy link
Contributor Author

Ok, I have closed it for now

@sanposhiho sanposhiho mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@alculquicondor alculquicondor

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khalilswdp @k8s-ci-robot @sanposhiho @alculquicondor @sivchari