-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update makefile for go-mod downloads #76
Update makefile for go-mod downloads #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pravarag, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pravarag |
Thanks, though I'm still looking for ways to test the integration if that's possible. Otherwise will open this and other PR to be merged. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As part of this change, we are adding an entry into the Makefile to include
go-mod downloads
so that those can be referred into prow job configs.Which issue(s) this PR fixes:
Fixes #56
Special notes for your reviewer:
This is a WIP PR
/label tide/merge-method-squash