-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to reflect the addition of PriorityClass #78
Update README.md to reflect the addition of PriorityClass #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please add priority class here as well.
https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/docs/how-it-works.md#1-users-request-creating-resource
I have updated how-it-works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work @khalilswdp
We finally complete supporting PritorityClass 🎉
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khalilswdp, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @sanposhiho for helping me throughout my first ever contribution to the open source! This is one of the happiest days in my life! |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updated the image on README.md to include PriorityClass, as well as added PriorityClass as a resource that we can simulate.
Which issue(s) this PR fixes:
This PR is related to #27
Special notes for your reviewer:
If there are other changes that I need to make, please tell me and I'll do them.
/label tide/merge-method-squash