code review

kubernetes-sigs · Mar 17, 2020 · b038ea8 · b038ea8
1 parent fc26389
commit b038ea8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 33 deletions.
diff --git a/manifests/migrator.yaml b/manifests/migrator.yaml
@@ -15,7 +15,6 @@ spec:
       labels:
         app: migrator
     spec:
-      serviceAccountName: storage-version-migration-migrator-sa
       containers:
       - name: migrator
         image: REGISTRY/storage-version-migration-migrator:VERSION

diff --git a/manifests/namespace-rbac.yaml b/manifests/namespace-rbac.yaml
@@ -17,18 +17,6 @@ rules:
 ---
 kind: ClusterRole
 apiVersion: rbac.authorization.k8s.io/v1
-metadata:
-  name: storage-version-migration-migrator
-rules:
-- apiGroups: ["*"]
-  resources: ["*"]
-  verbs: ["get", "list", "update"]
-- apiGroups: ["migration.k8s.io"]
-  resources: ["storageversionmigrations"]
-  verbs: ["watch"]
----
-kind: ClusterRole
-apiVersion: rbac.authorization.k8s.io/v1
 metadata:
   name: storage-version-migration-crd-creator
 rules:
@@ -55,7 +43,7 @@ subjects:
   namespace: NAMESPACE
 roleRef:
   kind: ClusterRole
-  name: storage-version-migration-migrator
+  name: cluster-admin
   apiGroup: rbac.authorization.k8s.io
 ---
 kind: ClusterRoleBinding
@@ -96,22 +84,3 @@ roleRef:
   kind: ClusterRole
   name: storage-version-migration-initializer
   apiGroup: rbac.authorization.k8s.io
----
-kind: ServiceAccount
-apiVersion: v1
-metadata:
-  namespace: NAMESPACE
-  name: storage-version-migration-migrator-sa
----
-kind: ClusterRoleBinding
-apiVersion: rbac.authorization.k8s.io/v1
-metadata:
-  name: storage-version-migration-migrator-sa
-subjects:
-  - kind: ServiceAccount
-    name: storage-version-migration-migrator-sa
-    namespace: NAMESPACE
-roleRef:
-  kind: ClusterRole
-  name: cluster-admin
-  apiGroup: rbac.authorization.k8s.io