Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella issue: migration performance improvement #78

Open
1 of 3 tasks
roycaihw opened this issue Oct 5, 2020 · 5 comments
Open
1 of 3 tasks

Umbrella issue: migration performance improvement #78

roycaihw opened this issue Oct 5, 2020 · 5 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@roycaihw
Copy link
Member

roycaihw commented Oct 5, 2020

Talked with @caesarxuchao. There are a few potential performance improvement we can do to the migrator controller:

  • Don't retry on UPDATE conflict. A conflict means the object has been written by another client, and has the up-to-date storage version.
  • Don't deserialize GET result before UPDATE. We already skip doing conversion to tolerate potential client-server skew. We can skip doing (de)serialization and just putting the data blob we got.
  • Don't GET. Same as don't retry on UPDATE, we can skip GET and use the result from the LIST. We do this already.

/priority important-long-term
/kind cleanup

@k8s-ci-robot
Copy link
Contributor

@roycaihw: The label(s) priority/important-long-term cannot be applied, because the repository doesn't have them

In response to this:

Talked with @caesarxuchao. There are a few potential performance improvement we can do to the migrator controller:

  • Don't retry on UPDATE conflict. A conflict means the object has been written by another client, and has the up-to-date storage version.
  • Don't deserialize GET result before UPDATE. We already skip doing conversion to tolerate potential client-server skew. We can skip doing (de)serialization and just putting the data blob we got.
  • Don't GET. Same as don't retry on UPDATE, we can skip GET and use the result from the LIST. We do this already.

/priority important-long-term
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 5, 2020
@roycaihw
Copy link
Member Author

roycaihw commented Oct 5, 2020

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 5, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 2, 2021
@roycaihw
Copy link
Member Author

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants