bump to kube 1.17 #50

vareti · 2019-12-11T20:46:24Z

This PR aims to rebase this repo with Kubernetes 1.17

k8s-ci-robot · 2019-12-11T20:46:27Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-12-11T20:46:32Z

Welcome @vareti!

It looks like this is your first PR to kubernetes-sigs/kube-storage-version-migrator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kube-storage-version-migrator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-12-11T20:46:32Z

Hi @vareti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vareti · 2019-12-11T20:59:03Z

/check-cla

deads2k · 2019-12-11T21:11:24Z

/ok-to-test

vareti · 2019-12-16T15:24:44Z

Closing this pull request as it is not needed anymore by library-go

caesarxuchao · 2019-12-17T18:32:20Z

/assign

caesarxuchao · 2019-12-17T18:35:01Z

Gopkg.toml

@@ -41,31 +41,31 @@

 [[constraint]]
  name = "k8s.io/api"
-  version = "kubernetes-1.16.2"
+  version = "kubernetes-1.17.0-rc.2"


We shouldn't use the rc version.

I am in the process of pushing a new commit with v0.17.0 tag. Will push the changes once I done.

Thanks for reviewing

sanchezl · 2019-12-17T19:09:14Z

/test pull-kube-storage-version-migrator-disruptive

vareti · 2019-12-17T23:13:16Z

/test pull-kube-storage-version-migrator-manually-launched-e2e

vareti · 2019-12-17T23:50:57Z

/retest

caesarxuchao · 2019-12-17T23:58:25Z

The disruptive test is flaky. Created #51.

sanchezl · 2019-12-18T13:04:43Z

/test pull-kube-storage-version-migrator-disruptive

vareti · 2019-12-18T16:57:40Z

/retest

sanchezl · 2019-12-18T20:54:24Z

/test pull-kube-storage-version-migrator-disruptive

vareti · 2019-12-18T22:11:55Z

/retest

vareti · 2019-12-18T23:02:52Z

/retest

vareti · 2019-12-19T15:37:22Z

/test pull-kube-storage-version-migrator-disruptive

deads2k · 2019-12-20T13:56:09Z

The disruptive test is flaky. Created #51.

flaky or broken?

@vareti please open a zero diff change and get some test history on it to compare.

vareti · 2019-12-20T15:33:17Z

flaky or broken?

@vareti please open a zero diff change and get some test history on it to compare.

@deads2k created #52 and will try to get test history. Can I get an tag ok-to-test on that PR?

vareti · 2019-12-20T20:43:10Z

/test pull-kube-storage-version-migrator-disruptive

sanchezl · 2020-01-06T19:44:24Z

/test pull-kube-storage-version-migrator-disruptive

sttts · 2020-01-08T09:05:12Z

Is the last commit intentional or just for debugging CI?

sttts · 2020-01-08T09:05:23Z

Otherwise lgtm.

deads2k · 2020-01-08T20:29:19Z

test/e2e/tests/chaos.go

+			if err != nil {
+				util.Logf("unable to get list of storage version migrations: %s", err)
+			} else {
+				for _, migration := range listOfMigrations.Items {


nesting this an extra level deep looks questionable to me. If you want to have this information, why don't you dump it somewhere where you aren't already in a loop of other resources?

deads2k · 2020-01-08T20:30:02Z

fix or remove the last commit.

/lgtm
/approve
/hold

holding for the debugging commit to be resolved.

k8s-ci-robot · 2020-01-08T20:30:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, vareti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vareti · 2020-01-09T13:27:45Z

@sttts @deads2k removed the last commit. it was added to debug disruptive test failure.

sanchezl · 2020-01-09T15:42:19Z

/test pull-kube-storage-version-migrator-disruptive
tests running slow again :-(

deads2k · 2020-01-09T18:21:38Z

/lgtm
/hold cancel

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2019

k8s-ci-robot requested review from caesarxuchao and deads2k December 11, 2019 20:46

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 11, 2019

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 11, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2019

vareti closed this Dec 16, 2019

deads2k reopened this Dec 17, 2019

k8s-ci-robot assigned caesarxuchao Dec 17, 2019

caesarxuchao reviewed Dec 17, 2019

View reviewed changes

vareti force-pushed the upstream-1.17 branch 3 times, most recently from 07db5f3 to 3d30daf Compare December 17, 2019 22:56

vareti added 2 commits December 17, 2019 17:03

Gopkg.toml changes

a07ab2e

bump(*): v0.17.0

a6fd766

vareti force-pushed the upstream-1.17 branch from 3d30daf to a6fd766 Compare December 17, 2019 23:04

vareti force-pushed the upstream-1.17 branch from 81fdd15 to 2b9b868 Compare December 20, 2019 19:46

deads2k reviewed Jan 8, 2020

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2020

k8s-ci-robot assigned deads2k Jan 8, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020

vareti force-pushed the upstream-1.17 branch from 2b9b868 to a6fd766 Compare January 9, 2020 13:25

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2020

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 9, 2020

k8s-ci-robot merged commit ece39bd into kubernetes-sigs:master Jan 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump to kube 1.17 #50

bump to kube 1.17 #50

vareti commented Dec 11, 2019

k8s-ci-robot commented Dec 11, 2019

k8s-ci-robot commented Dec 11, 2019

k8s-ci-robot commented Dec 11, 2019

vareti commented Dec 11, 2019

deads2k commented Dec 11, 2019

vareti commented Dec 16, 2019

caesarxuchao commented Dec 17, 2019

caesarxuchao Dec 17, 2019

vareti Dec 17, 2019

vareti Dec 17, 2019

sanchezl commented Dec 17, 2019

vareti commented Dec 17, 2019

vareti commented Dec 17, 2019

caesarxuchao commented Dec 17, 2019

sanchezl commented Dec 18, 2019

vareti commented Dec 18, 2019

sanchezl commented Dec 18, 2019

vareti commented Dec 18, 2019

vareti commented Dec 18, 2019

vareti commented Dec 19, 2019

deads2k commented Dec 20, 2019

vareti commented Dec 20, 2019 •

edited

Loading

vareti commented Dec 20, 2019

sanchezl commented Jan 6, 2020

sttts commented Jan 8, 2020

sttts commented Jan 8, 2020

deads2k Jan 8, 2020

deads2k commented Jan 8, 2020

k8s-ci-robot commented Jan 8, 2020

vareti commented Jan 9, 2020

sanchezl commented Jan 9, 2020

deads2k commented Jan 9, 2020

bump to kube 1.17 #50

bump to kube 1.17 #50

Conversation

vareti commented Dec 11, 2019

k8s-ci-robot commented Dec 11, 2019

k8s-ci-robot commented Dec 11, 2019

k8s-ci-robot commented Dec 11, 2019

vareti commented Dec 11, 2019

deads2k commented Dec 11, 2019

vareti commented Dec 16, 2019

caesarxuchao commented Dec 17, 2019

caesarxuchao Dec 17, 2019

Choose a reason for hiding this comment

vareti Dec 17, 2019

Choose a reason for hiding this comment

vareti Dec 17, 2019

Choose a reason for hiding this comment

sanchezl commented Dec 17, 2019

vareti commented Dec 17, 2019

vareti commented Dec 17, 2019

caesarxuchao commented Dec 17, 2019

sanchezl commented Dec 18, 2019

vareti commented Dec 18, 2019

sanchezl commented Dec 18, 2019

vareti commented Dec 18, 2019

vareti commented Dec 18, 2019

vareti commented Dec 19, 2019

deads2k commented Dec 20, 2019

vareti commented Dec 20, 2019 • edited Loading

vareti commented Dec 20, 2019

sanchezl commented Jan 6, 2020

sttts commented Jan 8, 2020

sttts commented Jan 8, 2020

deads2k Jan 8, 2020

Choose a reason for hiding this comment

deads2k commented Jan 8, 2020

k8s-ci-robot commented Jan 8, 2020

vareti commented Jan 9, 2020

sanchezl commented Jan 9, 2020

deads2k commented Jan 9, 2020

vareti commented Dec 20, 2019 •

edited

Loading