-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to kube 1.17 #50
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @vareti! |
Hi @vareti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
/ok-to-test |
Closing this pull request as it is not needed anymore by library-go |
/assign |
Gopkg.toml
Outdated
@@ -41,31 +41,31 @@ | |||
|
|||
[[constraint]] | |||
name = "k8s.io/api" | |||
version = "kubernetes-1.16.2" | |||
version = "kubernetes-1.17.0-rc.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use the rc version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in the process of pushing a new commit with v0.17.0
tag. Will push the changes once I done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing
/test pull-kube-storage-version-migrator-disruptive |
07db5f3
to
3d30daf
Compare
3d30daf
to
a6fd766
Compare
/test pull-kube-storage-version-migrator-manually-launched-e2e |
/retest |
The disruptive test is flaky. Created #51. |
/test pull-kube-storage-version-migrator-disruptive |
/retest |
/test pull-kube-storage-version-migrator-disruptive |
/retest |
1 similar comment
/retest |
/test pull-kube-storage-version-migrator-disruptive |
81fdd15
to
2b9b868
Compare
/test pull-kube-storage-version-migrator-disruptive |
1 similar comment
/test pull-kube-storage-version-migrator-disruptive |
Is the last commit intentional or just for debugging CI? |
Otherwise lgtm. |
test/e2e/tests/chaos.go
Outdated
if err != nil { | ||
util.Logf("unable to get list of storage version migrations: %s", err) | ||
} else { | ||
for _, migration := range listOfMigrations.Items { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nesting this an extra level deep looks questionable to me. If you want to have this information, why don't you dump it somewhere where you aren't already in a loop of other resources?
fix or remove the last commit. /lgtm holding for the debugging commit to be resolved. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, vareti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kube-storage-version-migrator-disruptive |
/lgtm |
This PR aims to rebase this repo with Kubernetes 1.17