-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openAPIV3Schema to CRDs #56
Add openAPIV3Schema to CRDs #56
Conversation
Hi @sanchezl. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
hack/update-codegen.sh
Outdated
@@ -43,6 +44,16 @@ GOPATH=${WORK_DIR}/go/ go install k8s.io/code-generator/cmd/client-gen | |||
GOPATH=${WORK_DIR}/go/ go install k8s.io/code-generator/cmd/deepcopy-gen | |||
popd | |||
|
|||
git clone --branch v0.2.4 --depth 1 -c advice.detachedHead=false \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this fail on second invocation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Each invocation uses a new ${WORK_DIR}
.
/assign |
/retest |
ac5a3b4
to
2cf8e34
Compare
2cf8e34
to
89f02bd
Compare
- controller-gen only works with one resource per file
89f02bd
to
0061096
Compare
@@ -17,3 +17,63 @@ spec: | |||
- name: v1alpha1 | |||
served: true | |||
storage: true | |||
"validation": | |||
"openAPIV3Schema": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why these two lines are quoted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some encoding issue of the yaml library. We saw that before with controller-gen. Maybe @DirectXMan12 has an idea.
For documentation purpose, can you say in the first comment on why we want to add the openAPIV3Schema? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sanchezl: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Add openAPIV3Schema to CRD for custom resource validation.