Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Golang 1.20 and controller-runtime v0.15.0-alpha.0 #333

Closed
camilamacedo86 opened this issue May 8, 2023 · 3 comments
Closed

Bump Golang 1.20 and controller-runtime v0.15.0-alpha.0 #333

camilamacedo86 opened this issue May 8, 2023 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@camilamacedo86
Copy link
Member

What would you like to be added:

Why is this needed:

  • Solve technical depbits
  • so we can move forward with the required changes into Kubebuilder, either.
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label May 8, 2023
@stephanhorsthemke
Copy link
Contributor

Hey! I am somewhat blocked by this as I needed to upgrade some downstream dependencies to controller-runtime@v0.15.0-alpha.0 in order to work around some other dependency issues.

Here's what happens when running declarative pattern with that version atm.

$ go vet ./...                                                                                                                 
# sigs.k8s.io/kubebuilder-declarative-pattern/pkg/test/mocks
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/test/mocks/manager.go:48:25: cannot use &Manager{} (value of type *Manager) as manager.Manager value in variable declaration: *Manager does not implement manager.Manager (wrong type for method GetControllerOptions)
                have GetControllerOptions() "sigs.k8s.io/controller-runtime/pkg/config/v1alpha1".ControllerConfigurationSpec
                want GetControllerOptions() "sigs.k8s.io/controller-runtime/pkg/config".Controller
# sigs.k8s.io/kubebuilder-declarative-pattern/pkg/patterns/declarative
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/metrics.go:354:20: undefined: source.NewKindWithCache
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/metrics.go:356:22: cannot use recordTrigger{…} (value of type recordTrigger) as handler.EventHandler value in assignment: recordTrigger does not implement handler.EventHandler (wrong type for method Create)
                have Create("sigs.k8s.io/controller-runtime/pkg/event".CreateEvent, workqueue.RateLimitingInterface)
                want Create(context.Context, "sigs.k8s.io/controller-runtime/pkg/event".CreateEvent, workqueue.RateLimitingInterface)
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/metrics.go:534:30: cannot use recordTrigger{} (value of type recordTrigger) as handler.EventHandler value in variable declaration: recordTrigger does not implement handler.EventHandler (wrong type for method Create)
                have Create("sigs.k8s.io/controller-runtime/pkg/event".CreateEvent, workqueue.RateLimitingInterface)
                want Create(context.Context, "sigs.k8s.io/controller-runtime/pkg/event".CreateEvent, workqueue.RateLimitingInterface)
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/watch.go:103:45: not enough arguments in call to apiutil.NewDiscoveryRESTMapper
        have (*rest.Config)
        want (*rest.Config, *http.Client)
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/watch.go:124:6: src.InjectStopChannel undefined (type *source.Channel has no field or method InjectStopChannel)

@camilamacedo86
Copy link
Member Author

It is done. So I am closing this issue

@atoato88
Copy link
Contributor

Thank you for closing this, I forgot that..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
3 participants