Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller runtime to v0.15.0 #337

Merged
merged 5 commits into from
Jun 4, 2023
Merged

Bump controller runtime to v0.15.0 #337

merged 5 commits into from
Jun 4, 2023

Conversation

kkkkun
Copy link
Member

@kkkkun kkkkun commented May 23, 2023 •
edited
Loading

xref #335

Upgrade controller-runtime to v0.15.0, which is block kubernetes-sigs/kubebuilder#3421

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # #333

Special notes for your reviewer:

Additional documentation:

stephanhorsthemke and others added 4 commits May 11, 2023 10:17
@stephanhorsthemke
bump controller-runtime, fix breaking changes
6ddcfe7
@stephanhorsthemke
This commit includes topics following:
25e96fc 
- update expected*.yaml
- update test.sh for getting kubectl v1.27 instead of v1.26
- update guestbook_controller
@kkkkun
fix ut failed
6c4c641
@kkkkun
bump controller-runtime to v0.15.0
8e81e61
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kkkkun!

It looks like this is your first PR to kubernetes-sigs/kubebuilder-declarative-pattern 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder-declarative-pattern has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kkkkun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 23, 2023
@kkkkun kkkkun mentioned this pull request May 24, 2023
Closed
@atoato88
Copy link
Contributor

/ok-to-test
I added a label to test. By this, we can check the result by prow on this PR.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2023
atoato88
atoato88 reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment.

examples/guestbook-operator/controllers/guestbook_controller.go Outdated Show resolved Hide resolved
@kkkkun @atoato88
Update examples/guestbook-operator/controllers/guestbook_controller.go
ac2b8d8 
Update syntax error

Co-authored-by: atoato88 <akihito-inou@nec.com>
@kkkkun
Copy link
Member Author

kkkkun commented May 24, 2023

I left a comment.

The tests passed. Thanks.

@atoato88
Copy link
Contributor

I have informed @justinsb on #335 , but I would like to confirm with him regarding the validity of this revision.
I apologize for repeating my statement.

@kkkkun
Copy link
Member Author

kkkkun commented May 25, 2023

We need this PR for kubebuider. Could you please review this @stephanhorsthemke @camilamacedo86

@atoato88
Copy link
Contributor

/lgtm

There have been no changes for about 1 week.
We need to move forward to release kubebuilder.

/assign @justinsb
Gentle ping.
Could you review this PR?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2023
@atoato88
Copy link
Contributor

atoato88 commented Jun 4, 2023

/approve
I acknowledge that we have not made progress, but we need to move forward.

@justinsb
I apologize for approving this PR without your comments. Please feel free to comment if you have any.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, kkkkun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9a41055 into kubernetes-sigs:master Jun 4, 2023
1 check passed
@kkkkun
Copy link
Member Author

kkkkun commented Jun 5, 2023

We need a tag.

@kkkkun kkkkun deleted the bump-controller-runtime branch June 5, 2023 02:45
@atoato88
Copy link
Contributor

atoato88 commented Jun 7, 2023

@justinsb
Could you add a tag against the current content?

@kkkkun
Copy link
Member Author

kkkkun commented Jun 8, 2023

@justinsb Could you add a tag against the current content?
Actually it's not need tag. It's used commit id.
kubernetes-sigs/kubebuilder@d5ff1ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

@johnsonj johnsonj Awaiting requested review from johnsonj

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

@atoato88 atoato88

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kkkkun @k8s-ci-robot @atoato88 @justinsb @stephanhorsthemke