-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
running kubectl apply in higher level #211
Conversation
Hi @xuzhenglun. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xuzhenglun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
052672d
to
4afb81d
Compare
8cad241
to
b390bde
Compare
/hold cancel |
please take a look at this PR too. thanks |
panic("implement me") | ||
} | ||
|
||
func NewCmdApply(ioStreams genericclioptions.IOStreams) (*cobra.Command, *apply.ApplyOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, It's copied from k/kubectl
. In the NewCmdApply
function, ApplyOptions
is never returned, so I didn't find a way to reuse that piece of code.
In the previous implementation, some codes are copied from Complete too, with some customize modification, Which can be very easy to make mistakes. I agreedDirectApplier
is implemented very trickly indeed.
@xuzhenglun: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(Deleted reply; wrong thread) |
What this PR does / why we need it:
fix #201
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation: