-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set dummy name for apply on direct.go #225
Set dummy name for apply on direct.go #225
Conversation
This commit sets filename field to dummy name for appling manifest. Before this commit, operator said errors followings: must specify one of -f and -k
/rename Set dummy name for apply on direct.go |
/retitle Set dummy name for apply on direct.go oh, command miss... |
Thanks for fixing @atoato88 ... this was an unfortunate change in a library that was supposed to simplify things :-( With server-side-apply, I'm not sure how much it is helping us. We also have https://github.com/kubernetes/kops/pull/13753/files in another project (kOps) which could be a better applier, and our appliers are now pluggable. In any case, thanks for this and sorry about the delay! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atoato88, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you to mention me and suggestion for good implementation. |
Awesome, thank you both! |
What this PR does / why we need it:
This PR sets filename field with dummy name for appling manifest.
Before this PR, operator said errors followings:
ERROR applying manifest {"error": "error getting apply options: must specify one of -f and -k"}
I checked that this PR fixed current bug, but it's pretty rough, I think.
Which issue(s) this PR fixes:
Fixes #224
Special notes for your reviewer:
Currently, update is pretty rough, but root cause is discovered.
Feel free to comment more good approach.
Additional documentation:
NONE