Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dummy name for apply on direct.go #225

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

atoato88
Copy link
Contributor

What this PR does / why we need it:

This PR sets filename field with dummy name for appling manifest.
Before this PR, operator said errors followings:
ERROR applying manifest {"error": "error getting apply options: must specify one of -f and -k"}

I checked that this PR fixed current bug, but it's pretty rough, I think.

Which issue(s) this PR fixes:

Fixes #224

Special notes for your reviewer:

Currently, update is pretty rough, but root cause is discovered.
Feel free to comment more good approach.

Additional documentation:
NONE

This commit sets filename field to dummy name for appling manifest.
Before this commit, operator said errors followings:
must specify one of -f and -k
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2022
@atoato88
Copy link
Contributor Author

/rename Set dummy name for apply on direct.go

@atoato88
Copy link
Contributor Author

/retitle Set dummy name for apply on direct.go

oh, command miss...

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Set dummy name to run apply from direct.go Set dummy name for apply on direct.go Jun 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2022
@atoato88
Copy link
Contributor Author

/assign @justinsb
I created this for fixing #224 which is noted on here.
Could you review this?

I think that this PR fixes issue, but it's rough approach.
Could you suggest some ideas for this?

@jcanseco
Copy link
Contributor

@atoato88 thanks for looking into this!

@justinsb Gentle ping: Can you take a look at this when you get the chance? This impacts us as well.

@justinsb
Copy link
Contributor

justinsb commented Jul 2, 2022

Thanks for fixing @atoato88 ... this was an unfortunate change in a library that was supposed to simplify things :-( With server-side-apply, I'm not sure how much it is helping us. We also have https://github.com/kubernetes/kops/pull/13753/files in another project (kOps) which could be a better applier, and our appliers are now pluggable.

In any case, thanks for this and sorry about the delay!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16c3ecf into kubernetes-sigs:master Jul 2, 2022
@atoato88
Copy link
Contributor Author

atoato88 commented Jul 2, 2022

Thank you to mention me and suggestion for good implementation.
I'll check taht 😄

@jcanseco
Copy link
Contributor

jcanseco commented Jul 6, 2022

Awesome, thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error getting apply options: must specify one of -f and -k
4 participants