-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use apply set tooling in apply set applier #336
fix: use apply set tooling in apply set applier #336
Conversation
Welcome @ChristopherFry! |
Hi @ChristopherFry. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc yuwenma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. one minor comment
/lgtm |
/ok-to-test |
/retest |
1 similar comment
/retest |
Thanks @ChristopherFry /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristopherFry, justinsb, yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This pull request fixes an issue where the
updateParentLabelsAndAnnotations
function always updates the parent object. This was due to theapplyset.kubernetes.io/tooling
annotation being set to a different value in the kubectl apply package than what the apply set applier expected.