Create abstraction layer over controller-runtime/client-go versions #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/wip |
k8s-ci-robot
added
the
size/XL
justinsb
force-pushed
the
version_independent
branch
2 times, most recently
from
8c82662
to
d33e962
Compare
|
Thank you so much for adding this abstraction layer. LGTM (looks like the test caught some additional cases need to fix). |
justinsb
force-pushed
the
version_independent
branch
2 times, most recently
from
accf6e4
to
a1d7789
Compare
commonclient contains wrappers around functions we use from controller-runtime which have changed between 0.11 and 0.15 (the version range we are supporting currently). This allows for buildtags to be used to select a previous version of controller-runtime, without needing to carry patches.
justinsb
force-pushed
the
version_independent
branch
from
a1d7789
to
1eff23c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an abstraction layer so that we are less dependent on a particular version of client-go / controller-runtime. The intent here is that controllers can work with multiple versions of client-go/controller-runtime, and thus a wide range of k8s versions.