⚠️ Bump controller-runtime to 0.16.1 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
justinsb
commented
Sep 11, 2023
justinsb
commented
- Update controller-runtime to 0.16.1
- Update code for controller-runtime 0.16.0
- Deprecate client-side validation in the direct applier
We create a simple helper script, and call it from the github action.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Minor changes
The kube 1.28 libraries made client-side validation much harder. We should be using server-side validation anyway.
justinsb
force-pushed
the
bump_controller_runtime_to_0_16
branch
from
a28bcba
to
b083920
Compare
yuwenma
reviewed
Sep 13, 2023
| @@ -47,7 +47,7 @@ jobs: | |||
|
|
|||
| - uses: actions/checkout@v2 | |||
|
|
|||
| - run: go mod tidy | |||
| - run: dev/format-gomod | |||
yuwenma
approved these changes
Sep 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.