-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow tools to be installed with newer versions of go #358
chore: allow tools to be installed with newer versions of go #358
Conversation
Hi @ChristopherFry. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
controller-gen: $(CONTROLLER_GEN) ## Download controller-gen locally if necessary. If wrong version is installed, it will be overwritten. | ||
$(CONTROLLER_GEN): $(LOCALBIN) | ||
test -s $(LOCALBIN)/controller-gen && $(LOCALBIN)/controller-gen --version | grep -q $(CONTROLLER_TOOLS_VERSION) || \ | ||
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@$(CONTROLLER_TOOLS_VERSION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just go run
these now, not sure if that's better though!
Thanks @ChristopherFry . I've started using But this simplifies the build scripts, so... /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristopherFry, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change fixes the example guestbook operator Makefile by allowing the
controller-gen
andkustomize
tools to be successfully installed.Previously any Make commands requiring one of these tools such as
make generate
would fail since thego-get-tool
function would only download the package with go get however not install the package with go install, where go get no longer installs executables since Go 1.17, https://go.dev/doc/go-get-install-deprecation.The updated Makefile commands for
controller-gen
andkustomize
aligns with the Makefile kubebuilder generates for new projects, https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v3/Makefile.