Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owners: add tomasaschan to reviewers #381

Conversation

justinsb
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2024
@justinsb
Copy link
Contributor Author

/hold for input from tomasaschan

@tomasaschan would like to be a reviewer? (With a view to getting ownership in time, but we're not supposed to start you as an owner) I think you have demonstrated a deep understanding of the code and an ability to contribute.

cc @atoato88 and @johnsonj - do you agree with this suggestion?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2024
@tomasaschan
Copy link
Member

I'd be happy to!

@tomasaschan
Copy link
Member

/lgtm

Just to formally indicate this (even though it won't work until this is merged, IIUC).

@k8s-ci-robot
Copy link
Contributor

@tomasaschan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Just to formally indicate this (even though it won't work until this is merged, IIUC).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnsonj
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@johnsonj: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb
Copy link
Contributor Author

changing LGTM is restricted to collaborators

Well that's not good, either prow is having a moment or maybe we've change the config (so that approvers can't LGTM?)... I'll try to figure out what's going on here

@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@atoato88
Copy link
Contributor

k8s-ci-bot said:

User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@tomasaschan is not member of org member?
Could you reat the document here for becoming the member of that.

@tomasaschan
Copy link
Member

Hum. I think I have everything in place except two sponsors from different companies. @atoato88 @justinsb OK if I name the two of you as my sponsors? (I can't tell from your GH profile if you're also a Googler, @atoato88 ...)

@tomasaschan
Copy link
Member

kubernetes/org#4837

@atoato88
Copy link
Contributor

I can become your sponsor!
I know your activities on this repo and I am not a googler. 😄

@atoato88
Copy link
Contributor

Thank you for mentioning me, I commented on kubernetes/org#4837

@tomasaschan
Copy link
Member

Thank you! Then I think we just need a +1 from Justin there too, which I suppose will have to wait until I after kubecon :)

@tomasaschan
Copy link
Member

I've now been added as a member of the org, so this should be unblocked!

/hold cancel

(probably won't work)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2024
@tomasaschan
Copy link
Member

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 83bd9c0 into kubernetes-sigs:master Apr 4, 2024
6 checks passed
@atoato88
Copy link
Contributor

atoato88 commented Apr 10, 2024

Thank you for catching up this PR and I'm very appreciate that you joined this repo! 😄

tomasaschan added a commit to tomasaschan/kubebuilder-declarative-pattern that referenced this pull request May 23, 2024
This was discussed already in kubernetes-sigs#381 but hasn't happened yet.
tomasaschan added a commit to tomasaschan/kubebuilder-declarative-pattern that referenced this pull request May 23, 2024
This was discussed already in kubernetes-sigs#381 but hasn't happened yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants