-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct path to PodSpec for CronJob #388
fix: use correct path to PodSpec for CronJob #388
Conversation
CronJob has a different path to the PodSpec from the other currently supported types of ImageRegistryTransform. This fixes the image transform logic to find the correct path.
Welcome @sdowell! |
Hi @sdowell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
I wonder if I have access to do this: /ok-to-test |
/assign @atoato88 |
/ok-to-test This LGTM. We probably want a release note, I was thinking of reviving/updating the files in our docs/releases folder |
/test |
@sdowell: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
@atoato88 please take a look |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CronJob has a different path to the PodSpec from the other currently supported types of ImageRegistryTransform. This fixes the image transform logic to find the correct path.
What this PR does / why we need it: The
ImageRegistryTransform
used for private registries supports a few enumerated types, includingCronJob
. The samePodSpec
path is used for all types, howeverCronJob
has a different path. This change adds special handling for theCronJob
case.Which issue(s) this PR fixes: N/A
Special notes for your reviewer: N/A
Additional documentation: N/A