fix: use correct path to PodSpec for CronJob

[sdowell]

CronJob has a different path to the PodSpec from the other currently supported types of ImageRegistryTransform. This fixes the image transform logic to find the correct path.

What this PR does / why we need it: The ImageRegistryTransform used for private registries supports a few enumerated types, including CronJob. The same PodSpec path is used for all types, however CronJob has a different path. This change adds special handling for the CronJob case.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Additional documentation: N/A

[k8s-ci-robot]

Welcome @sdowell!

It looks like this is your first PR to kubernetes-sigs/kubebuilder-declarative-pattern 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder-declarative-pattern has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sdowell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tomasaschan]

/lgtm

[tomasaschan]

I wonder if I have access to do this:

/ok-to-test

[tomasaschan]

/assign @atoato88

[justinsb]

/ok-to-test

This LGTM. We probably want a release note, I was thinking of reviving/updating the files in our docs/releases folder

[sdowell]

/test

[k8s-ci-robot]

@sdowell: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test pull-declarative-test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sdowell]

/test all

[sdowell]

@atoato88 please take a look

[justinsb]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment