Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more health info as well as counts in Apply results #393

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

barney-s
Copy link
Contributor

@barney-s barney-s commented Jun 6, 2024

What this PR does / why we need it:

Expose more health info as well as counts in Apply results
When using applyset as a library we sometimes want more information about the last applied set.
Currently we get boolean (IsHealthy, IsAllApplied).
Having more is useful when consuming this as a library.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2024
@barney-s
Copy link
Contributor Author

barney-s commented Jun 6, 2024

/test pull-declarative-test

@barney-s
Copy link
Contributor Author

barney-s commented Jun 7, 2024

/assign @justinsb

PruneFailCount int
HealthyCount int
UnhealthyCount int
Objects []ObjectStatus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these were previously unexported so that we could change the implementation and instead offer higher-level methods (AllApplied, All healthy). What signals do we want to expose? And which objects appear in Objects? One answer could be that we every object in the manifest appears in Objects, and then we populate Applied, Is healthy etc at the object level. But what about objects we are pruning - should they appear in Objects?

I guess the question is ... what do you want to do with this information? Do we have to commit to exposing everything, or can we make more incremental changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mostly want just the objects. Updated the PR to reflect that. Not exposing the counts anymore. Just the list of object status.

@justinsb
Copy link
Contributor

Looks great now, thanks @barney-s

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit a248ed1 into kubernetes-sigs:master Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants