Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nested manifests in object transforms #397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdowell
Copy link
Contributor

@sdowell sdowell commented Jun 11, 2024

This change adds support for applying object transforms to nested manifests. The nested manifest pattern is a pattern in which an object has a string field which consists of its own yaml manifest.

As an example, a ConfigMap may contain a manifest bundle in one of its data fields.

A nested manifest will recurse and apply all object transforms to the underlying objects and then write the result back to the parent object.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @sdowell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 11, 2024
@sdowell
Copy link
Contributor Author

sdowell commented Jun 11, 2024

/assign @justinsb

This change adds support for applying object transforms to nested
manifests. The nested manifest pattern is a pattern in which an object
has a string field which consists of its own yaml manifest.

As an example, a ConfigMap may contain a manifest bundle in one of its
data fields.

A nested manifest will recurse and apply all object transforms to the
underlying objects and then write the result back to the parent object.
@sdowell sdowell force-pushed the registry-transform-nested-manifest branch from 3bc63ec to b5a5e00 Compare June 11, 2024 22:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdowell
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdowell sdowell changed the title feat: nested manifests in registry transforms feat: nested manifests in object transforms Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants