fix test failure and add comments

kubernetes-sigs · May 31, 2018 · 0fddc34 · 0fddc34
1 parent e2d7f7d
commit 0fddc34
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/cmd/internal/codegen/parse/crd.go b/cmd/internal/codegen/parse/crd.go
@@ -297,6 +297,8 @@ func (b *APIs) parseArrayValidation(t *types.Type, found sets.String, comments [
 		Type:  "array",
 		Items: &v1beta1.JSONSchemaPropsOrArray{Schema: &items},
 	}
+	// To represent byte arrays in the generated code, the property of the OpenAPI definition
+	// should have string as its type and byte as its format.
 	if t.Name.Name == "[]byte" {
 		props.Type = "string"
 		props.Format = "byte"

diff --git a/test.sh b/test.sh
@@ -530,7 +530,7 @@ function test_crd_validation {
     Alias string \`json:"alias"\`\
     // +kubebuilder:validation:Enum=1,2,3\
     Rank int \`json:"rank"\`\
-    Comment []byte \`json:"comment"\`\
+    Comment []byte \`json:"comment,omitempty"\`\
   ' pkg/apis/got/v1beta1/house_types.go
 
   kubebuilder generate