Skip to content

Commit

Permalink
🌱 Image name edge cases covered (#3514)
Browse files Browse the repository at this point in the history
imagename edge case cover
  • Loading branch information
Sajiyah-Salat committed Aug 15, 2023
1 parent 32720bc commit 136aac6
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions test/e2e/utils/test_context.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,16 @@ func (t *TestContext) Destroy() {
//nolint:gosec
// if image name is not present or not provided skip execution of docker command
if t.ImageName != "" {
cmd := exec.Command("docker", "rmi", "-f", t.ImageName)
if _, err := t.Run(cmd); err != nil {
warnError(err)
// Check white space from image name
if len(strings.TrimSpace(t.ImageName)) == 0 {
fmt.Println("Image not set, skip cleaning up of docker image")
} else {
cmd := exec.Command("docker", "rmi", "-f", t.ImageName)
if _, err := t.Run(cmd); err != nil {
warnError(err)
}
}

}
if err := os.RemoveAll(t.Dir); err != nil {
warnError(err)
Expand Down

0 comments on commit 136aac6

Please sign in to comment.