Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lichuqiang committed May 30, 2018
1 parent a5c5dd9 commit 1b9b748
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/e2e/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func initConfig(testSuffix string) *config {
kind: "Foo" + testSuffix,
installName: installName,
namespace: testNamespace,
controllerImageName: "gcr.io/kubeships/controller-manager:" + testSuffix,
controllerImageName: "e2e-test/controller-manager:" + testSuffix,
workDir: filepath.Join(framework.TestContext.ProjectDir, "e2e-"+testSuffix),
}
}
Expand Down
1 change: 0 additions & 1 deletion test/e2e/e2e.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import (
"github.com/kubernetes-sigs/kubebuilder/test/e2e/framework"
"github.com/kubernetes-sigs/kubebuilder/test/e2e/framework/ginkgowrapper"
e2einternal "github.com/kubernetes-sigs/kubebuilder/test/internal/e2e"

. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"

Expand Down
2 changes: 1 addition & 1 deletion test/internal/e2e/kubebuildertest.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ func (kt *KubebuilderTest) runCommand(cmd *exec.Cmd) ([]byte, error) {
command := strings.Join(cmd.Args, " ")
output, err := cmd.Output()
if err != nil {
return output, fmt.Errorf("%s failed with error: %v", command, err)
return output, fmt.Errorf("%s failed with error: %s", command, string(output))
}
log.Printf("%s finished successfully", command)
return output, nil
Expand Down

0 comments on commit 1b9b748

Please sign in to comment.