🐛 regression - extracommands require a valid PROJECT file again

Handle 3-alpha based on review comments Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
kubernetes-sigs · Apr 8, 2021 · 2a1ff46 · 2a1ff46
1 parent 84f357b
commit 2a1ff46
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/pkg/cli/cli.go b/pkg/cli/cli.go
@@ -144,8 +144,14 @@ func newCLI(options ...Option) (*CLI, error) {
 func (c *CLI) buildCmd() error {
 	c.cmd = c.newRootCmd()
 
+	var uve *config.UnsupportedVersionError
+
 	// Get project version and plugin keys.
-	if err := c.getInfo(); err != nil {
+	switch err := c.getInfo(); {
+	case err == nil:
+		// do nothing if it's nil
+	case !errors.As(err, &uve):
+		// Ignore 3-alpha error
 		return err
 	}
 

diff --git a/pkg/config/errors.go b/pkg/config/errors.go
@@ -28,7 +28,7 @@ type UnsupportedVersionError struct {
 }
 
 // Error implements error interface
-func (e UnsupportedVersionError) Error() string {
+func (e *UnsupportedVersionError) Error() string {
 	return fmt.Sprintf("version %s is not supported", e.Version)
 }
 

diff --git a/pkg/config/registry.go b/pkg/config/registry.go
@@ -31,5 +31,5 @@ func New(version Version) (Config, error) {
 		return constructor(), nil
 	}
 
-	return nil, UnsupportedVersionError{Version: version}
+	return nil, &UnsupportedVersionError{Version: version}
 }