🌱 fix testdata/project-v4 samples by removing call to generate Lakers…

… controller without resource (#4129)

fix: testdata project-v4 samples by removing call to generate Lakers controller without resource

We are removing the Laker from here because we already test the creation of controllers without resource in the multi-group. Also, if we keep it here it will not allow we have a very comprehensive test e2e tests for this sample since it is an edge case and we users need to customize the controller for not see error likes

```
ERROR	setup	unable to create controller	{"controller": "Laker", "error": "one of For() or Named() must be called"}
main.main
	/workspace/cmd/main.go:193
runtime.main
	/usr/local/go/src/runtime/proc.go:271
```

We cannot do that manually just for our e2e tests on the samples

test/testdata/generate.sh

@@ -53,8 +53,6 @@ function scaffold_test_project {
       $kb create api --group crew --version v1 --kind Admiral --controller=true --resource=true --namespaced=false --make=false
       $kb create webhook --group crew --version v1 --kind Admiral --defaulting
     fi
-
-    $kb create api --group crew --version v1 --kind Laker --controller=true --resource=false --make=false
   elif [[ $project =~ multigroup ]]; then
     header_text 'Switching to multigroup layout ...'
     $kb edit --multigroup=true

testdata/project-v4/PROJECT

@@ -45,9 +45,4 @@ resources:
   webhooks:
     defaulting: true
     webhookVersion: v1
-- controller: true
-  domain: testproject.org
-  group: crew
-  kind: Laker
-  version: v1
 version: "3"

testdata/project-v4/cmd/main.go

@@ -186,13 +186,6 @@ func main() {
 			os.Exit(1)
 		}
 	}
-	if err = (&controller.LakerReconciler{
-		Client: mgr.GetClient(),
-		Scheme: mgr.GetScheme(),
-	}).SetupWithManager(mgr); err != nil {
-		setupLog.Error(err, "unable to create controller", "controller", "Laker")
-		os.Exit(1)
-	}
 	// +kubebuilder:scaffold:builder
 
 	if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {

testdata/project-v4/config/rbac/role.yaml

@@ -10,7 +10,6 @@ rules:
   - admirales
   - captains
   - firstmates
-  - lakers
   verbs:
   - create
   - delete
@@ -25,7 +24,6 @@ rules:
   - admirales/finalizers
   - captains/finalizers
   - firstmates/finalizers
-  - lakers/finalizers
   verbs:
   - update
 - apiGroups:
@@ -34,7 +32,6 @@ rules:
   - admirales/status
   - captains/status
   - firstmates/status
-  - lakers/status
   verbs:
   - get
   - patch

testdata/project-v4/dist/install.yaml

@@ -410,7 +410,6 @@ rules:
   - admirales
   - captains
   - firstmates
-  - lakers
   verbs:
   - create
   - delete
@@ -425,7 +424,6 @@ rules:
   - admirales/finalizers
   - captains/finalizers
   - firstmates/finalizers
-  - lakers/finalizers
   verbs:
   - update
 - apiGroups:
@@ -434,7 +432,6 @@ rules:
   - admirales/status
   - captains/status
   - firstmates/status
-  - lakers/status
   verbs:
   - get
   - patch