Skip to content

Commit

Permalink
🐛 *: Replace 'docker build . -t ${IMG}' with '-t ${IMG} .'
Browse files Browse the repository at this point in the history
Because folks may have 'docker' aliased to 'podman', and Podman
prefers options before positional arguments [1]:

  $ podman build --help | grep CONTEXT-DIRECTORY
     podman build [command options] CONTEXT-DIRECTORY | URL

Generated with:

  $ sed -i 's/ . -t \([^ ]*\)/ -t \1 ./' $(git grep -l 'docker.*build.* \. ')
  $ git checkout HEAD -- docs/kubebuilder_v0_v1_difference.md

The docs checkout leaves historical docs alone [2].

[1]: containers/podman#2811
[2]: #1817 (comment)
  • Loading branch information
wking committed Nov 16, 2020
1 parent c158f4f commit 3b13378
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion docs/book/src/cronjob-tutorial/testdata/project/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ generate: controller-gen

# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ generate: controller-gen

# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion pkg/plugin/v2/scaffolds/internal/templates/makefile.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ generate: controller-gen
# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .
# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion pkg/plugin/v3/scaffolds/internal/templates/makefile.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ generate: controller-gen
# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .
# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v2-addon/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ generate: controller-gen

# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v2-multigroup/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ generate: controller-gen

# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v2/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ generate: controller-gen

# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v3-addon/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ generate: controller-gen

# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v3-multigroup/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ generate: controller-gen

# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v3/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ generate: controller-gen

# Build the docker image
docker-build: test
docker build . -t ${IMG}
docker build -t ${IMG} .

# Push the docker image
docker-push:
Expand Down

0 comments on commit 3b13378

Please sign in to comment.