Skip to content

Commit

Permalink
Merge pull request #1548 from imjoey/doc_webhook_for_core_types
Browse files Browse the repository at this point in the history
docs: Fix a literal typo and incorrect list
  • Loading branch information
k8s-ci-robot committed Jun 4, 2020
2 parents cd5eed9 + cabe808 commit 44997bf
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions docs/book/src/reference/webhook-for-core-types.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

It is very easy to build admission webhooks for CRDs, which has been covered in
the CronJob tutorial. Given that kubebuilder doesn't support webhook scaffolding
for core types, you have to use the library from controler-runtime to handle it.
for core types, you have to use the library from controller-runtime to handle it.
There is an [example](https://github.com/kubernetes-sigs/controller-runtime/tree/master/examples/builtins)
in controller-runtime.

Expand Down Expand Up @@ -67,6 +67,7 @@ You need to ensure the path here match the path in the marker.
## Deploy

Deploying it is just like deploying a webhook server for CRD. You need to
1) provision the serving certificate 2) deploy the server
1) provision the serving certificate
2) deploy the server

You can follow the [tutorial](/cronjob-tutorial/running.md).

0 comments on commit 44997bf

Please sign in to comment.