Merge pull request #49 from briantkennedy/master

Fix an issue in types.ReconcileKey.String()
kubernetes-sigs · Apr 4, 2018 · 6bf7b0b · 6bf7b0b
2 parents ed1c5d9 + f53d2c3
commit 6bf7b0b
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/pkg/controller/types/types.go b/pkg/controller/types/types.go
@@ -37,5 +37,17 @@ type ReconcileKey struct {
 }
 
 func (r ReconcileKey) String() string {
+	if r.Namespace == "" {
+		return r.Name
+	}
 	return r.Namespace + "/" + r.Name
 }
+
+// ParseReconcileKey returns the ReconcileKey that has been encoded into a string.
+func ParseReconcileKey(key string) (ReconcileKey, error) {
+	namespace, name, err := cache.SplitMetaNamespaceKey(key)
+	if err != nil {
+		return ReconcileKey{}, err
+	}
+	return ReconcileKey{Name: name, Namespace: namespace}, nil
+}