Skip to content

Commit

Permalink
[fix: go/v3, go/v4] Remove stale imports
Browse files Browse the repository at this point in the history 
This PR removes the stale import: "pkg/envtest/printer" that is not needed
after migrating to ginko/v2.

Controller-runtime v0.14.0+ has migrated to use ginko/v2 and thereby removed
"printer" package. The imports were still being scaffolded though not used in the
codebase.

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
  • Loading branch information
@varshaprasad96
varshaprasad96 committed Mar 8, 2023
1 parent 014e08c commit 8284311
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion pkg/plugins/golang/v3/scaffolds/internal/templates/api/webhook_suitetest.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ import (
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/envtest"
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
)
Expand Down
1 change: 0 additions & 1 deletion pkg/plugins/golang/v3/scaffolds/internal/templates/controllers/controller_suitetest.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ import (
"k8s.io/client-go/rest"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/envtest"
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
%s
Expand Down
1 change: 0 additions & 1 deletion pkg/plugins/golang/v4/scaffolds/internal/templates/api/webhook_suitetest.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ import (
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/envtest"
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
)
Expand Down
1 change: 0 additions & 1 deletion pkg/plugins/golang/v4/scaffolds/internal/templates/controllers/controller_suitetest.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ import (
"k8s.io/client-go/rest"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/envtest"
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
%s
Expand Down

0 comments on commit 8284311

Please sign in to comment.