test

kubernetes-sigs · Apr 26, 2024 · bfd3de0 · bfd3de0
1 parent a584763
commit bfd3de0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...book/src/multiversion-tutorial/testdata/project/internal/controller/cronjob_controller.go b/...book/src/multiversion-tutorial/testdata/project/internal/controller/cronjob_controller.go
@@ -542,7 +542,7 @@ will automatically call Reconcile on the underlying CronJob when a Job changes,
 deleted, etc.
 */
 var (
-	jobOwnerKey = ".metadata.controller"
+	jobOwnerKey = "metadata.my-controller"
 	apiGVStr    = batchv1.GroupVersion.String()
 )
 
@@ -565,8 +565,8 @@ func (r *CronJobReconciler) SetupWithManager(mgr ctrl.Manager) error {
 			return nil
 		}
 
-		// ...and if so, return it
-		return []string{owner.Name}
+		// Return the job's owner name using a label set on the job itself.
+		return []string{job.Labels[jobOwnerKey]}
 	}); err != nil {
 		return err
 	}

diff --git a/...src/multiversion-tutorial/testdata/project/internal/controller/cronjob_controller_test.go b/...src/multiversion-tutorial/testdata/project/internal/controller/cronjob_controller_test.go
@@ -49,6 +49,9 @@ var _ = Describe("CronJob Controller", func() {
 					ObjectMeta: metav1.ObjectMeta{
 						Name:      resourceName,
 						Namespace: "default",
+						Labels: map[string]string{
+							jobOwnerKey: "metadata.my-controller",
+						},
 					},
 					Spec: batchv1.CronJobSpec{
 						Schedule: "*/1 * * * *", // Example: runs every minute